New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: event emission on writing error receipts for channel upgrades #5549

Merged

charleenfei merged 10 commits into main from charly/error_receipt_events

Jan 10, 2024

Contributor

charleenfei commented Jan 8, 2024

Description

closes comment from @DimitrisJim

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against the correct branch (see CONTRIBUTING.md).
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards and Go style guide.
Wrote unit and integration tests.
Updated relevant documentation (docs/) or specification (x/<module>/spec/).
Added relevant godoc comments.
Provide a commit message to be used for the changelog entry in the PR description for review.
Re-reviewed Files changed in the Github PR explorer.
Review Codecov Report in the comment section below once CI passes.

charleenfei added 2 commits

January 8, 2024 20:17


          test for event emission on error receipt

c6e81c5


          update all tests to pass in ctx

fd5a7b3

charleenfei requested review from colin-axner, AdityaSripal and damiannolan as code owners

January 8, 2024 19:42

charleenfei commented

View reviewed changes

modules/core/keeper/msg_server_test.go

+              						channeltypes.AttributeKeyUpgradeSequence:       fmt.Sprintf("%d", channel.UpgradeSequence),
+              					},
+              					channeltypes.EventTypeChannelUpgradeError: {
+              						channeltypes.AttributeKeyPortID:             path.EndpointA.ChannelConfig.PortID,

Contributor Author

charleenfei Jan 8, 2024 •

edited

Loading

added error receipt event test here

charleenfei commented

View reviewed changes

modules/core/keeper/msg_server_test.go

+              					channeltypes.EventTypeChannelUpgradeError: {
+              						channeltypes.AttributeKeyPortID:             path.EndpointB.ChannelConfig.PortID,
+              						channeltypes.AttributeKeyChannelID:          path.EndpointB.ChannelID,
+              						channeltypes.AttributeCounterpartyPortID:    path.EndpointA.ChannelConfig.PortID,

Contributor Author

charleenfei Jan 8, 2024

added error receipt event test here

charleenfei commented

View reviewed changes

modules/core/keeper/msg_server_test.go

+              				expEvents := ibctesting.EventsMap{
+              					channeltypes.EventTypeChannelUpgradeError: {
+              						channeltypes.AttributeKeyPortID:             path.EndpointB.ChannelConfig.PortID,
+              						channeltypes.AttributeKeyChannelID:          path.EndpointB.ChannelID,

Contributor Author

charleenfei Jan 8, 2024

added error receipt event test here on abort

modules/core/keeper/msg_server_test.go

+              				expEvents := ibctesting.EventsMap{
+              					channeltypes.EventTypeChannelUpgradeError: {
+              						channeltypes.AttributeKeyPortID:             path.EndpointB.ChannelConfig.PortID,
+              						channeltypes.AttributeKeyChannelID:          path.EndpointB.ChannelID,

Contributor Author

charleenfei Jan 8, 2024

added error receipt event test here on abort

modules/core/keeper/msg_server_test.go

+              				expEvents := ibctesting.EventsMap{
+              					channeltypes.EventTypeChannelUpgradeError: {
+              						channeltypes.AttributeKeyPortID:             path.EndpointB.ChannelConfig.PortID,
+              						channeltypes.AttributeKeyChannelID:          path.EndpointB.ChannelID,

Contributor Author

charleenfei Jan 8, 2024

added error receipt event test here on abort

modules/core/keeper/msg_server_test.go

+              						channeltypes.AttributeKeyUpgradeSequence:       fmt.Sprintf("%d", channel.UpgradeSequence),
+              					},
+              					channeltypes.EventTypeChannelUpgradeError: {
+              						channeltypes.AttributeKeyPortID:             path.EndpointA.ChannelConfig.PortID,

Contributor Author

charleenfei Jan 8, 2024

added error receipt event test here

DimitrisJim added channel-upgradability backport-to-v8.1.x labels

DimitrisJim approved these changes

View reviewed changes

Contributor

DimitrisJim left a comment

I think this lgtm, thanks! added a small suggestion for also checking the case that no events are emitted.

modules/core/keeper/msg_server_test.go Outdated Show resolved Hide resolved

damiannolan reviewed

View reviewed changes

modules/core/keeper/msg_server_test.go Outdated Show resolved Hide resolved

charleenfei and others added 7 commits

January 9, 2024 18:02


          pr review

60f4ea5


          Merge branch 'main' into charly/error_receipt_events

d86f287


          lint

8cac58d


          Merge branch 'charly/error_receipt_events' of github.com:cosmos/ibc-g…

1c8325c

…o into charly/error_receipt_events


          nit: reorder expResult args, move events after res.

0d72fb6


          Merge branch 'main' into charly/error_receipt_events

e4d7d73


          Merge branch 'main' into charly/error_receipt_events

229dc87

DimitrisJim approved these changes

View reviewed changes

Contributor

DimitrisJim left a comment

pushed a quick nit on arg order. ACK changes

DimitrisJim added the priority label

chatton approved these changes

View reviewed changes

Contributor

chatton left a comment

Sorry for the late review! LGTM, using the events as an arg cleans things up a good bit!


          Merge branch 'main' into charly/error_receipt_events

53bd676

charleenfei requested a review from damiannolan

January 10, 2024 13:16

damiannolan approved these changes

View reviewed changes

charleenfei merged commit d487fb8 into main

62 checks passed

charleenfei deleted the charly/error_receipt_events branch

January 10, 2024 13:32

mergify bot pushed a commit that referenced this pull request


          test: event emission on writing error receipts for channel upgrades (#…

9ee5e8e

…5549)

(cherry picked from commit d487fb8)

mergify bot mentioned this pull request

test: event emission on writing error receipts for channel upgrades (backport #5549) #5564

Merged

colin-axner pushed a commit that referenced this pull request


          test: event emission on writing error receipts for channel upgrades (#…

89d3c1c

…5549) (#5564)

(cherry picked from commit d487fb8)

Co-authored-by: Charly <charly@interchain.io>

charleenfei added a commit that referenced this pull request


          test: event emission on writing error receipts for channel upgrades (#…

36f2848

…5549)

charleenfei added a commit that referenced this pull request


          test: event emission on writing error receipts for channel upgrades (#…

87cf8b2

…5549)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DimitrisJim DimitrisJim approved these changes

chatton chatton approved these changes

damiannolan damiannolan approved these changes

colin-axner Awaiting requested review from colin-axner

AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

Labels

channel-upgradability priority