Docs for channel upgrades CLI #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan,
DimitrisJim and
srdtrk
as code owners
DimitrisJim
approved these changes
Jan 9, 2024
Comment on lines
174
to
175
| The following example, would submit a governance proposal with the specified deposit, title and summary which would | ||
| contain a `MsgChanUpgradeInit` for all `OPEN` channels whose port matches the regular expression `transfer`. |
There was a problem hiding this comment.
Suggested change
| The following example, would submit a governance proposal with the specified deposit, title and summary which would | |
| contain a `MsgChanUpgradeInit` for all `OPEN` channels whose port matches the regular expression `transfer`. | |
| The following example, would submit a governance proposal with the specified deposit, title and summary while also containing a `MsgChannelUpgradeInit` for all `OPEN` channels whose port matches the regular expression `transfer`. |
There was a problem hiding this comment.
i kind of prefer @chatton's version tbh bc the proposal is there to contain (approve) the MsgChannelUpgradeInit, but it's a super nit really.
There was a problem hiding this comment.
will leave as is if you guys are okay with it then?
There was a problem hiding this comment.
ah, maybe just the MsgChannelUpgradeInit as opposed to MsgChanUpgradeInit? (git diff isn't particularly good at showing the specific diffs).
Wording is perfectly fine by me either way!
There was a problem hiding this comment.
ah missed the typo, thanks @DimitrisJim
charleenfei
approved these changes
Jan 9, 2024
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
charleenfei
pushed a commit
that referenced
this pull request
Jan 11, 2024
charleenfei
pushed a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #5548
Also realizing, after this gets merged I can update #5504 to reference this CLI instead of gov submit proposal.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.