Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(core): allow huckleberry events with a prefix (backport #5541) #5574

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 11, 2024

This is an automatic backport of pull request #5541 done by Mergify.
Cherry-pick of 2375109 has failed:

On branch mergify/bp/release/v7.3.x/pr-5541
Your branch is up to date with 'origin/release/v7.3.x'.

You are currently cherry-picking commit 2375109a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   modules/core/keeper/events_test.go
	new file:   modules/core/keeper/export_test.go
	new file:   modules/core/types/events.go
	new file:   testing/mock/events.go
	modified:   testing/mock/ibc_module.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   modules/core/keeper/msg_server.go
	both modified:   modules/core/keeper/msg_server_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* feat: initial impl

* imp: moved event helpers to types and added tests

* imp(testing): added mock events to mock module

* test: added msg_server tests for application events

* imp: converted suffix to prefix

* docs: updated inline comments

* imp: review item

* test: review items

* imp: review items

(cherry picked from commit 2375109)

# Conflicts:
#	modules/core/keeper/msg_server.go
#	modules/core/keeper/msg_server_test.go
@srdtrk
Copy link
Member

srdtrk commented Jan 11, 2024

Also going to remove link checker in this PR

@srdtrk srdtrk removed the conflicts label Jan 11, 2024
@srdtrk srdtrk merged commit 825fe90 into release/v7.3.x Jan 11, 2024
14 checks passed
@srdtrk srdtrk deleted the mergify/bp/release/v7.3.x/pr-5541 branch January 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants