Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add default upgrade handler for v8.1 #5636

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

damiannolan
Copy link
Member

Description

Adds the default upgrade handler for v8.1.

ref: #5635


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@@ -107,10 +109,3 @@ func CreateV7LocalhostUpgradeHandler(
return mm.RunMigrations(ctx, configurator, vm)
}
}

// CreateV8UpgradeHandler creates an upgrade handler for the ibc-go/v8 SimApp upgrade.
func CreateV8UpgradeHandler(mm *module.Manager, configurator module.Configurator) upgradetypes.UpgradeHandler {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was never needed. Duplicate of CreateDefaultUpgradeHandler

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@DimitrisJim DimitrisJim added the priority PRs that need prompt reviews label Jan 17, 2024
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damiannolan damiannolan merged commit c5d8472 into main Jan 17, 2024
63 of 64 checks passed
@damiannolan damiannolan deleted the damian/5635-add-upgrade-handler-v81 branch January 17, 2024 15:38
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
damiannolan added a commit that referenced this pull request Jan 17, 2024
(cherry picked from commit c5d8472)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants