Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Enable/Disable controller/host on-chain params #566

Merged
merged 10 commits into from
Dec 1, 2021
Merged

Add Enable/Disable controller/host on-chain params #566

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aa508b2
add ica params
colin-axner Nov 26, 2021
5d009b5
regenerate params proto into host and controller submodules
colin-axner Nov 29, 2021
d0c6c0a
split params implementation into host/controller
colin-axner Nov 29, 2021
d43a945
add keeper params logic
colin-axner Nov 29, 2021
ff79bd9
Apply suggestions from code review
colin-axner Nov 30, 2021
cb0b4f8
fix merge conflicts
colin-axner Nov 30, 2021
4c47cd4
Merge branch 'colin/523-controller-host-param' of github.com:cosmos/i…
colin-axner Nov 30, 2021
df27451
add host genesis init/export params test case
colin-axner Nov 30, 2021
40a6382
fix merge conflicts with interchain-accounts branch
colin-axner Nov 30, 2021
b807529
add genesis validation for controller and host params
colin-axner Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/apps/27-interchain-accounts/types/genesis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ func (gs ControllerGenesisState) Validate() error {
}
}

if err := gs.Params.Validate(); err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these technically cannot return an error. Validate only checks that params contain a bool as its field (the compiler would break if it didn't)

Keeping here for when we add more params which do validation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I'll likely have something ready today. I'll just need to pull in your latest changes. Ack the additions :)

return err
}

return nil
}

Expand Down Expand Up @@ -127,5 +131,9 @@ func (gs HostGenesisState) Validate() error {
return err
}

if err := gs.Params.Validate(); err != nil {
return err
}

return nil
}