Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump cometbft to 0.38.4 in modules. #5662

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Conversation

DimitrisJim
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor Author

seems cometbft 0.38.3 changed an interface that made the cosmossdk version we depend on not compilable:

cosmos-sdk@v0.50.3/server/cmt_cmds.go:443:7: cannot use blockStoreDB (variable of type "github.com/cometbft/cometbft-db".DB) as "github.com/cometbft/cometbft-db".Batch value in argument to store.SaveBlockStoreState: "github.com/cometbft/cometbft-db".DB does not implement "github.com/cometbft/cometbft-db".Batch (missing method Write)) (typecheck)

@DimitrisJim
Copy link
Contributor Author

might need to hold off on this one.

@crodriguezvega
Copy link
Contributor

yes, it looks like... Let's wait for an SDK release that upgrades to it. Thanks for bundling the upgrade in a single PR, though.

@DimitrisJim DimitrisJim changed the title deps: bump cometbft to 0.38.3 in modules. deps: bump cometbft to 0.38.4 in modules. Jan 22, 2024
@DimitrisJim
Copy link
Contributor Author

bumping to 0.38.4 works out fine!

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @DimitrisJim!

@crodriguezvega crodriguezvega merged commit eeff754 into main Jan 22, 2024
81 checks passed
@crodriguezvega crodriguezvega deleted the deps/bump-comet branch January 22, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants