Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for fee events #5706

Merged
merged 27 commits into from
Feb 14, 2024
Merged

Add tests for fee events #5706

merged 27 commits into from
Feb 14, 2024

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jan 24, 2024

Description

Review after #5687
closes #2823


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@chatton chatton force-pushed the cian/issue#2823-fee-events branch from 5f3544f to be3e930 Compare January 24, 2024 12:08
@chatton chatton marked this pull request as ready for review February 8, 2024 11:24
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chatton for adding all these event tests!!

@chatton chatton enabled auto-merge (squash) February 14, 2024 14:11
@chatton chatton merged commit b68ba7d into main Feb 14, 2024
64 of 65 checks passed
@chatton chatton deleted the cian/issue#2823-fee-events branch February 14, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events unit testing across the board
3 participants