Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for querying the UpgradedClientState endpoint. #5711

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

DimitrisJim
Copy link
Contributor

Description

closes: #4142

Commit Message / Changelog Entry

tests: add coverage for querying for the UpgradedClientState.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim added the testing Testing package and unit/integration tests label Jan 24, 2024
@DimitrisJim DimitrisJim force-pushed the jim/4142-missing-cov-for-upgrade branch from 96b5730 to 8690396 Compare January 24, 2024 13:31
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the error assertions!

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb, @DimitrisJim!

modules/core/02-client/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
@DimitrisJim DimitrisJim enabled auto-merge (squash) January 24, 2024 21:03
@DimitrisJim DimitrisJim merged commit 942efd7 into main Jan 24, 2024
70 of 72 checks passed
@DimitrisJim DimitrisJim deleted the jim/4142-missing-cov-for-upgrade branch January 24, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing code coverage for grpc check in 02-client upgrade query
3 participants