test: add UpdateConnection to endpoint and update usages in tests. #5719
Conversation
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei and
chatton
as code owners
| connection := endpoint.GetConnection() | ||
| updater(&connection) | ||
|
|
||
| endpoint.SetConnection(connection) |
There was a problem hiding this comment.
don't need to commit and update client as original issue had. Lmk if it would be good to add for some reason.
There was a problem hiding this comment.
It's only necessary if we need to generate a proof on the modified connection
There was a problem hiding this comment.
you think its beneficial to slip it back in? don't currently do that atm but maybe in futureland?
There was a problem hiding this comment.
I think it could be done manually when required
DimitrisJim
changed the title
| connection := endpoint.GetConnection() | ||
| updater(&connection) | ||
|
|
||
| endpoint.SetConnection(connection) |
There was a problem hiding this comment.
It's only necessary if we need to generate a proof on the modified connection
Not for connection case thankfully! Only for channel updating func! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5719 +/- ##
==========================================
- Coverage 81.54% 81.50% -0.04%
==========================================
Files 199 199
Lines 15225 15225
==========================================
- Hits 12415 12409 -6
- Misses 2344 2349 +5
- Partials 466 467 +1 |
| connection := endpoint.GetConnection() | ||
| updater(&connection) | ||
|
|
||
| endpoint.SetConnection(connection) |
There was a problem hiding this comment.
I think it could be done manually when required
Description
closes: #3985
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.