refactor!: remove connection interface #5770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
colin-axner
added
the
type: code hygiene
damiannolan
approved these changes
Jan 30, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5770 +/- ##
=======================================
Coverage ? 81.55%
=======================================
Files ? 199
Lines ? 15180
Branches ? 0
=======================================
Hits ? 12380
Misses ? 2334
Partials ? 466
|
DimitrisJim
reviewed
Jan 30, 2024
| @@ -158,14 +158,6 @@ func (ClientState) VerifyClientConsensusState( | |||
| panic(errors.New("legacy solo machine is deprecated")) | |||
| } | |||
|
|
|||
| // VerifyConnectionState panics! | |||
| func (ClientState) VerifyConnectionState( | |||
There was a problem hiding this comment.
seems legacy solomachine has quite the legacy methods defined on it (Verify* family of funcs, CheckHeaderAndUpdateState etc)? Do we have an issue to clean those up? Do we have a bigger issue for legacy solomachine might be better q tho
There was a problem hiding this comment.
I think the answer is no to both questions! Definitely would be great to have an issue for both. I've just been removing unnecessary funcs as I bump into them
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.