Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: reorganize channel upgrade tests + add them to compatibility tests #5772

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Jan 30, 2024

Description

closes: #5611

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating the compatibility tests 🚀

@colin-axner colin-axner added the priority PRs that need prompt reviews label Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ffd91be) 81.55% compared to head (e3b9300) 81.55%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5772   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files         199      199           
  Lines       15180    15180           
=======================================
  Hits        12380    12380           
  Misses       2334     2334           
  Partials      466      466           
Files Coverage Δ
modules/core/04-channel/keeper/events.go 94.72% <100.00%> (ø)
modules/core/04-channel/keeper/packet.go 99.09% <100.00%> (ø)
modules/core/04-channel/keeper/timeout.go 95.39% <ø> (ø)
modules/core/04-channel/types/packet.go 67.56% <100.00%> (ø)
...27-interchain-accounts/controller/keeper/events.go 0.00% <0.00%> (ø)
.../apps/27-interchain-accounts/host/keeper/events.go 0.00% <0.00%> (ø)

Carlos Rodriguez added 2 commits January 30, 2024 20:27
@crodriguezvega crodriguezvega merged commit d330de7 into main Jan 30, 2024
116 checks passed
@crodriguezvega crodriguezvega deleted the carlos/add-channel-upgrades-compatibility-tests branch January 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate helper functions for e2e upgrade tests
4 participants