feat: allow module safe queries in ICA #5785

srdtrk · 2024-01-31T12:07:58Z

Description

closes: #5784

Commit Message / Changelog Entry

feat: allow module safe queries in ICA

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against the correct branch (see CONTRIBUTING.md).
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards and Go style guide.
Wrote unit and integration tests.
Updated relevant documentation (docs/) or specification (x/<module>/spec/).
Added relevant godoc comments.
Provide a commit message to be used for the changelog entry in the PR description for review.
Re-reviewed Files changed in the Github PR explorer.
Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

New Features
- Implemented a mechanism for whitelisting safe queries to enhance module query safety.
- Added a new message structure for defining query requests by interchain accounts.
- Introduced an RPC handler for safe queries with payload and response message definitions.
Tests
- Expanded test coverage to validate module query safety and successful execution of specific queries.
- Introduced test functions to ensure the correct functioning of query safelisting and transaction handling.
Documentation
- Updated the codec setup function to include interface registration for improved transaction handling.

codecov-commenter · 2024-01-31T12:15:51Z

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (310a4bd) 81.49% compared to head (578d006) 81.45%.
Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5785      +/-   ##
==========================================
- Coverage   81.49%   81.45%   -0.04%     
==========================================
  Files         199      200       +1     
  Lines       15203    15246      +43     
==========================================
+ Hits        12389    12419      +30     
- Misses       2348     2354       +6     
- Partials      466      473       +7

Files	Coverage Δ
.../apps/27-interchain-accounts/host/keeper/keeper.go	`90.07% <100.00%> (+0.07%)`	⬆️
modules/core/04-channel/keeper/keeper.go	`90.90% <100.00%> (+0.13%)`	⬆️
modules/core/04-channel/keeper/upgrade.go	`92.46% <100.00%> (+0.15%)`	⬆️
...s/27-interchain-accounts/host/keeper/msg_server.go	`76.31% <67.85%> (-23.69%)`	⬇️
...es/apps/27-interchain-accounts/host/types/query.go	`66.66% <66.66%> (ø)`
...les/apps/27-interchain-accounts/host/types/msgs.go	`44.00% <0.00%> (-56.00%)`	⬇️

... and 11 files with indirect coverage changes

coderabbitai · 2024-03-11T04:18:47Z

Walkthrough

The changes introduce a comprehensive framework for querying interchain accounts, enhancing transaction execution between chains using IBC protocols. This includes testing for query functionality, codec registration for transaction handling, and a safe query mechanism via whitelisting. Additionally, it aligns with the objective of providing a query API for Interchain Accounts, addressing the need for native query support alongside ICA transactions.

Changes

Files	Change Summary
`e2e/tests/interchain_accounts/query_test.go`	Provides test functionality for querying interchain accounts, verifying account interactions, and executing transactions between two chains using IBC protocols.
`e2e/testsuite/codec.go`	Added the registration of interfaces for transaction handling in the codec setup function.
`e2e/testsuite/tx.go`	Added a new function `QueryTxsByEvents` that runs the `QueryTxsByEvents` command on a given chain, allowing querying transactions by events. Also added a function `ExtractValueFromEvents` to extract values of attributes from a list of events.
`modules/apps/27-interchain-accounts/host/keeper/keeper.go`	Added imports for protobuf-related packages. Modified `NewKeeper` function signature to include `queryRouter` parameter. Initialized `queryRouter`, `mqsWhitelist`, and `mqsAllowList` in the `NewKeeper` function. Added functions to create whitelists of safe queries.
`modules/apps/27-interchain-accounts/host/keeper/keeper_test.go`	Added testing for query safety whitelisting and module queries with different scenarios.
`modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go`	Added tests for module query functionality with various scenarios including success, multiple queries, and failure cases.
`modules/apps/27-interchain-accounts/host/keeper/relay_test.go`	Added a test case for the successful execution of `icahosttypes.MsgModuleQuerySafe` within the `TestOnRecvPacket` function.
`modules/apps/27-interchain-accounts/host/types/codec.go`	Added the declaration for `MsgModuleQuerySafe{}` to the list of registered implementations. Added a test case for `MsgModuleQuerySafe` in `TestCodecTypeRegistration` function.
`modules/apps/27-interchain-accounts/host/types/msgs.go`	Added declarations for `MsgModuleQuerySafe` and its related functions. Updated `ValidateBasic` implementation for `MsgUpdateParams` to `sdk.HasValidateBasic`. Implemented `ValidateBasic` for `MsgModuleQuerySafe`.
`modules/apps/27-interchain-accounts/types/router.go`	Added a `QueryRouter` interface for ADR 021 query type routing.
`modules/callbacks/testing/simapp/app.go`, `modules/light-clients/08-wasm/testing/simapp/app.go`, `testing/simapp/app.go`	Adjusted function calls in `NewSimApp` to include `GRPCQueryRouter`.

Assessment against linked issues

Objective	Addressed	Explanation
Allow `module_query_safe` queries in ICA (#5784)	✅

Related issues

cosmos/ibc-go#5793: The changes do not directly address the objectives related to ICS20 V2 support for Multi Denom in the Cosmos IBC module, as the focus here is on interchain accounts and query functionality. However, the overall enhancement of IBC modules and testing could indirectly benefit the implementation and testing phases of ICS20 V2 support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

modules/apps/27-interchain-accounts/host/types/query.go

srdtrk · 2024-03-11T05:51:07Z

This PR is not ready to be merged because no e2e tests are written

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 8ab8f77 and 15a1ccd.

Files selected for processing (3)

e2e/tests/interchain_accounts/query_test.go (1 hunks)
e2e/testsuite/codec.go (2 hunks)
e2e/testsuite/tx.go (2 hunks)

Files skipped from review as they are similar to previous changes (3)

e2e/tests/interchain_accounts/query_test.go
e2e/testsuite/codec.go
e2e/testsuite/tx.go

modules/apps/27-interchain-accounts/host/keeper/keeper.go

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 15a1ccd and 4083edc.

Files selected for processing (3)

modules/apps/27-interchain-accounts/host/keeper/export_test.go (1 hunks)
modules/apps/27-interchain-accounts/host/keeper/keeper.go (5 hunks)
modules/apps/27-interchain-accounts/host/keeper/keeper_test.go (4 hunks)

Files skipped from review as they are similar to previous changes (2)

modules/apps/27-interchain-accounts/host/keeper/keeper.go
modules/apps/27-interchain-accounts/host/keeper/keeper_test.go

Additional comments: 1

modules/apps/27-interchain-accounts/host/keeper/export_test.go (1)

18-21: LGTM! This wrapper function NewModuleQuerySafeWhitelist is a good practice for enhancing testability of private functions without compromising encapsulation. It aligns well with the PR's objectives of improving the ICA module's functionality and ensuring comprehensive testing.

modules/apps/27-interchain-accounts/host/keeper/keeper.go

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 4083edc and b86b3a4.

Files selected for processing (4)

modules/apps/27-interchain-accounts/host/keeper/export_test.go (1 hunks)
modules/apps/27-interchain-accounts/host/keeper/keeper.go (5 hunks)
modules/apps/27-interchain-accounts/host/keeper/keeper_test.go (4 hunks)
modules/apps/27-interchain-accounts/host/keeper/msg_server.go (2 hunks)

Files skipped from review as they are similar to previous changes (3)

modules/apps/27-interchain-accounts/host/keeper/export_test.go
modules/apps/27-interchain-accounts/host/keeper/keeper_test.go
modules/apps/27-interchain-accounts/host/keeper/msg_server.go

Additional comments: 4

modules/apps/27-interchain-accounts/host/keeper/keeper.go (4)

8-13: The addition of protobuf-related imports is necessary for the new functionality related to module-safe queries. Ensure that these imports are used effectively within the file and that there are no unused imports to maintain code cleanliness.

45-49: The addition of msgRouter, queryRouter, and mqsAllowList to the Keeper struct supports the new module-safe queries functionality. It's good practice to document struct fields, especially when introducing new concepts like module-safe queries, to enhance code readability and maintainability.

Consider adding comments to these fields to explain their purpose and usage within the module.

61-61: The modification of the NewKeeper function signature to include a queryRouter parameter aligns with the introduction of module-safe queries. This change is crucial for routing queries appropriately within the ICA module.

82-83: Initializing queryRouter and mqsAllowList in the NewKeeper function is essential for setting up the module-safe queries functionality. However, the newModuleQuerySafeAllowList function call here uses panic for error handling, which might not align with the overall error handling strategy of the application.

Consider revising the error handling approach in newModuleQuerySafeAllowList to return an error and handle it appropriately in NewKeeper, enhancing the robustness of the module initialization process.

modules/apps/27-interchain-accounts/host/keeper/keeper.go

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between b86b3a4 and 72561cc.

Files selected for processing (1)

CHANGELOG.md (1 hunks)

Additional comments: 1

CHANGELOG.md (1)

55-56: The addition of a new transaction message for querying the chain in the apps/27-interchain-accounts module is well-documented in the CHANGELOG. This update provides clear information on the enhancement made to the ICA module, which is crucial for developers and users to understand the new capabilities introduced.

sonarqubecloud · 2024-03-27T09:09:48Z

Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

crodriguezvega · 2024-03-27T10:30:08Z

I will go ahead and merge the PR. Thank you @srdtrk for the superb work on this one. If someone would still like to do a review, please post your comments and we can deal with them in a separate PR. Once the backport for this PR is opened I will start working on reverting the API breaking change.

* imp: initial modification of tx.proto * imp: ran 'make proto-all' * fix: compiler errors * imp: added query router interface * imp: added queryRouter to icahost keeper * imp: improved proto definitions * imp: ran 'make proto-all' * imp: added sdk.Msg helpers * feat: basic implementation * style: improved field names * imp: ran 'make proto-all' * fix: compiler errors * imp: ran gofumpt * feat: tests passing * feat: tests improved * test: removed unneeded code * imp: improved 'IsModuleSafe' function * imp: added IsModuleQuerySafe to msg_server * imp: added more test cases * fix: callbacks compiler * fix: non determinancy issues * fix: added query msg to codec * imp: whitelist logic added * e2e: new test added * fix: new test * fix: test * fix: e2e * fix: e2e * imp(e2e): added the QueryTxsByEvents function * fix: e2e * e2e: lint fix * fix: e2e * e2e: debug * fix: e2e * test: debug helpers * debug * test: added codec_test case * imp: additional test case * imp: added important unit test * r4r * e2e: debug * imp: added logs * fix: e2e * fix: e2e * fix: e2e * imp: added height to proto response * imp: ran 'make proto-all' * imp: added height * e2e: updated e2e to test height * imp: review suggestions * e2e: remove unneeded log * refactor: refactored 'ExtractValueFromEvents' * e2e: review item * imp: review item * nit: review item * docs: added godocs * test: unit test for mqsWhitelist added * imp: added logging * style: rename to allow list * add changelog --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit eecfa5c) # Conflicts: # CHANGELOG.md # e2e/testsuite/codec.go # e2e/testsuite/tx.go # modules/apps/27-interchain-accounts/host/types/msgs.go # modules/light-clients/08-wasm/testing/simapp/app.go

crodriguezvega · 2024-03-27T10:59:05Z

modules/apps/27-interchain-accounts/host/types/msgs.go

+}
+
+// ValidateBasic implements sdk.HasValidateBasic
+func (msg MsgModuleQuerySafe) ValidateBasic() error {


Noticed in the backport PR that we don't have tests for this function.

* imp: initial modification of tx.proto * imp: ran 'make proto-all' * fix: compiler errors * imp: added query router interface * imp: added queryRouter to icahost keeper * imp: improved proto definitions * imp: ran 'make proto-all' * imp: added sdk.Msg helpers * feat: basic implementation * style: improved field names * imp: ran 'make proto-all' * fix: compiler errors * imp: ran gofumpt * feat: tests passing * feat: tests improved * test: removed unneeded code * imp: improved 'IsModuleSafe' function * imp: added IsModuleQuerySafe to msg_server * imp: added more test cases * fix: callbacks compiler * fix: non determinancy issues * fix: added query msg to codec * imp: whitelist logic added * e2e: new test added * fix: new test * fix: test * fix: e2e * fix: e2e * imp(e2e): added the QueryTxsByEvents function * fix: e2e * e2e: lint fix * fix: e2e * e2e: debug * fix: e2e * test: debug helpers * debug * test: added codec_test case * imp: additional test case * imp: added important unit test * r4r * e2e: debug * imp: added logs * fix: e2e * fix: e2e * fix: e2e * imp: added height to proto response * imp: ran 'make proto-all' * imp: added height * e2e: updated e2e to test height * imp: review suggestions * e2e: remove unneeded log * refactor: refactored 'ExtractValueFromEvents' * e2e: review item * imp: review item * nit: review item * docs: added godocs * test: unit test for mqsWhitelist added * imp: added logging * style: rename to allow list * add changelog --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit eecfa5c) # Conflicts: # e2e/testsuite/codec.go # e2e/testsuite/tx.go # modules/apps/27-interchain-accounts/host/keeper/keeper.go # modules/apps/27-interchain-accounts/host/keeper/keeper_test.go # modules/apps/27-interchain-accounts/host/keeper/msg_server.go # modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go # modules/apps/27-interchain-accounts/host/types/codec.go # modules/apps/27-interchain-accounts/host/types/codec_test.go # modules/apps/27-interchain-accounts/host/types/host.pb.go # modules/apps/27-interchain-accounts/host/types/msgs.go # modules/apps/27-interchain-accounts/host/types/tx.pb.go # modules/apps/callbacks/testing/simapp/app.go # modules/light-clients/08-wasm/testing/simapp/app.go # proto/ibc/applications/interchain_accounts/host/v1/tx.proto # testing/simapp/app.go

* feat: allow module safe queries in ICA (#5785) * imp: initial modification of tx.proto * imp: ran 'make proto-all' * fix: compiler errors * imp: added query router interface * imp: added queryRouter to icahost keeper * imp: improved proto definitions * imp: ran 'make proto-all' * imp: added sdk.Msg helpers * feat: basic implementation * style: improved field names * imp: ran 'make proto-all' * fix: compiler errors * imp: ran gofumpt * feat: tests passing * feat: tests improved * test: removed unneeded code * imp: improved 'IsModuleSafe' function * imp: added IsModuleQuerySafe to msg_server * imp: added more test cases * fix: callbacks compiler * fix: non determinancy issues * fix: added query msg to codec * imp: whitelist logic added * e2e: new test added * fix: new test * fix: test * fix: e2e * fix: e2e * imp(e2e): added the QueryTxsByEvents function * fix: e2e * e2e: lint fix * fix: e2e * e2e: debug * fix: e2e * test: debug helpers * debug * test: added codec_test case * imp: additional test case * imp: added important unit test * r4r * e2e: debug * imp: added logs * fix: e2e * fix: e2e * fix: e2e * imp: added height to proto response * imp: ran 'make proto-all' * imp: added height * e2e: updated e2e to test height * imp: review suggestions * e2e: remove unneeded log * refactor: refactored 'ExtractValueFromEvents' * e2e: review item * imp: review item * nit: review item * docs: added godocs * test: unit test for mqsWhitelist added * imp: added logging * style: rename to allow list * add changelog --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit eecfa5c) # Conflicts: # CHANGELOG.md # e2e/testsuite/codec.go # e2e/testsuite/tx.go # modules/apps/27-interchain-accounts/host/types/msgs.go # modules/light-clients/08-wasm/testing/simapp/app.go * fix conflicts + add GetSigners to message * delete e2e and 08-wasm folders * add tests for message functions * use boolean for expected test result * revert API breaking change in ica host NewKeeper * lint * panic if query router is nil --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Damian Nolan <damiannolan@gmail.com>

* feat: allow module safe queries in ICA (#5785) * imp: initial modification of tx.proto * imp: ran 'make proto-all' * fix: compiler errors * imp: added query router interface * imp: added queryRouter to icahost keeper * imp: improved proto definitions * imp: ran 'make proto-all' * imp: added sdk.Msg helpers * feat: basic implementation * style: improved field names * imp: ran 'make proto-all' * fix: compiler errors * imp: ran gofumpt * feat: tests passing * feat: tests improved * test: removed unneeded code * imp: improved 'IsModuleSafe' function * imp: added IsModuleQuerySafe to msg_server * imp: added more test cases * fix: callbacks compiler * fix: non determinancy issues * fix: added query msg to codec * imp: whitelist logic added * e2e: new test added * fix: new test * fix: test * fix: e2e * fix: e2e * imp(e2e): added the QueryTxsByEvents function * fix: e2e * e2e: lint fix * fix: e2e * e2e: debug * fix: e2e * test: debug helpers * debug * test: added codec_test case * imp: additional test case * imp: added important unit test * r4r * e2e: debug * imp: added logs * fix: e2e * fix: e2e * fix: e2e * imp: added height to proto response * imp: ran 'make proto-all' * imp: added height * e2e: updated e2e to test height * imp: review suggestions * e2e: remove unneeded log * refactor: refactored 'ExtractValueFromEvents' * e2e: review item * imp: review item * nit: review item * docs: added godocs * test: unit test for mqsWhitelist added * imp: added logging * style: rename to allow list * add changelog --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit eecfa5c) # Conflicts: # e2e/testsuite/codec.go # e2e/testsuite/tx.go # modules/apps/27-interchain-accounts/host/keeper/keeper.go # modules/apps/27-interchain-accounts/host/keeper/keeper_test.go # modules/apps/27-interchain-accounts/host/keeper/msg_server.go # modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go # modules/apps/27-interchain-accounts/host/types/codec.go # modules/apps/27-interchain-accounts/host/types/codec_test.go # modules/apps/27-interchain-accounts/host/types/host.pb.go # modules/apps/27-interchain-accounts/host/types/msgs.go # modules/apps/27-interchain-accounts/host/types/tx.pb.go # modules/apps/callbacks/testing/simapp/app.go # modules/light-clients/08-wasm/testing/simapp/app.go # proto/ibc/applications/interchain_accounts/host/v1/tx.proto # testing/simapp/app.go * fix conflicts * fix tests * gofumpt * do not set ica query router for callbacks * pls * fix comment * panic if query router is nil * break loop earlier * workaround for using module safe queries of x/staking * add comment --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

srdtrk added 19 commits January 29, 2024 16:49

imp: initial modification of tx.proto

3224eb1

imp: ran 'make proto-all'

6e1d4de

fix: compiler errors

d2ce96f

imp: added query router interface

47d8fb1

imp: added queryRouter to icahost keeper

47fdeed

imp: improved proto definitions

adea94e

imp: ran 'make proto-all'

4c9ee5e

imp: added sdk.Msg helpers

4846f80

feat: basic implementation

ea72aed

style: improved field names

cf6db81

imp: ran 'make proto-all'

322734e

fix: compiler errors

0195490

imp: ran gofumpt

915d515

feat: tests passing

5665d04

feat: tests improved

a8fa43a

test: removed unneeded code

330bd24

imp: improved 'IsModuleSafe' function

f4ac337

imp: added IsModuleQuerySafe to msg_server

67a1870

imp: added more test cases

e1853fb

srdtrk added 27-interchain-accounts type: feature New features, sub-features or integrations change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) labels Jan 31, 2024

fix: callbacks compiler

578d006

srdtrk added 2 commits January 31, 2024 14:59

Merge branch 'main' into serdar/focus-ica-icq

d29250b

Merge branch 'main' into serdar/focus-ica-icq

2298e31

srdtrk commented Mar 11, 2024

View reviewed changes

modules/apps/27-interchain-accounts/host/types/query.go Outdated Show resolved Hide resolved

fix: non determinancy issues

53cb24e

srdtrk added 2 commits March 26, 2024 12:24

imp: review item

f2fb96c

nit: review item

15a1ccd

coderabbitai bot reviewed Mar 26, 2024

View reviewed changes

crodriguezvega reviewed Mar 26, 2024

View reviewed changes

modules/apps/27-interchain-accounts/host/keeper/keeper.go Outdated Show resolved Hide resolved

srdtrk added 2 commits March 26, 2024 15:08

docs: added godocs

d76ff53

test: unit test for mqsWhitelist added

4083edc

coderabbitai bot reviewed Mar 26, 2024

View reviewed changes

damiannolan reviewed Mar 26, 2024

View reviewed changes

modules/apps/27-interchain-accounts/host/keeper/keeper.go Outdated Show resolved Hide resolved

srdtrk added 2 commits March 26, 2024 16:50

imp: added logging

17531fa

style: rename to allow list

b86b3a4

coderabbitai bot reviewed Mar 26, 2024

View reviewed changes

modules/apps/27-interchain-accounts/host/keeper/keeper.go Show resolved Hide resolved

crodriguezvega removed the backport-to-v7.4.x label Mar 26, 2024

Carlos Rodriguez added 2 commits March 26, 2024 19:50

Merge branch 'main' into serdar/focus-ica-icq

a854551

add changelog

72561cc

coderabbitai bot reviewed Mar 26, 2024

View reviewed changes

Merge branch 'main' into serdar/focus-ica-icq

ec6df04

crodriguezvega merged commit eecfa5c into main Mar 27, 2024
88 checks passed

crodriguezvega deleted the serdar/focus-ica-icq branch March 27, 2024 10:30

mergify bot mentioned this pull request Mar 27, 2024

feat: allow module safe queries in ICA (backport #5785) #6065

Merged

9 tasks

crodriguezvega reviewed Mar 27, 2024

View reviewed changes

crodriguezvega added the backport-to-v7.5.x label Apr 9, 2024

mergify bot mentioned this pull request Apr 9, 2024

feat: allow module safe queries in ICA (backport #5785) #6123

Merged

9 tasks

GAtom22 mentioned this pull request May 30, 2024

Application panics on ICA host keeper instantiation #6435

Closed

3 tasks

0xpatrickdev mentioned this pull request Aug 8, 2024

orchestration: query chains that do not have async-icq enabled Agoric/agoric-sdk#9326

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow module safe queries in ICA #5785

feat: allow module safe queries in ICA #5785

srdtrk commented Jan 31, 2024 •

edited by coderabbitai bot

Loading

codecov-commenter commented Jan 31, 2024

coderabbitai bot commented Mar 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

srdtrk commented Mar 11, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

sonarqubecloud bot commented Mar 27, 2024

crodriguezvega commented Mar 27, 2024

crodriguezvega Mar 27, 2024

feat: allow module safe queries in ICA #5785

feat: allow module safe queries in ICA #5785

Conversation

srdtrk commented Jan 31, 2024 • edited by coderabbitai bot Loading

Description

Commit Message / Changelog Entry

Summary by CodeRabbit

codecov-commenter commented Jan 31, 2024

Codecov Report

coderabbitai bot commented Mar 11, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

srdtrk commented Mar 11, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 27, 2024

Quality Gate passed for 'ibc-go'

crodriguezvega commented Mar 27, 2024

crodriguezvega Mar 27, 2024

Choose a reason for hiding this comment

srdtrk commented Jan 31, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 11, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)