refactor: remove hardcoding of tendermint self client validation #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
damian/5310-conditional-clients-querier
to
main
February 15, 2024 12:32
…ient validation of consensus parameters
damiannolan
force-pushed
the
damian/cian/custom-validate-self-client
branch
from
dd58c61
to
97509fe
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| package keeper | ||
|
|
||
| import ( | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
3 tasks
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
chatton and
DimitrisJim
as code owners
|
This is targeting a feat branch to bundle work for builds |
charleenfei
approved these changes
Feb 19, 2024
chatton
approved these changes
Feb 19, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Co-Authored-By: @chatton
Open to naming suggestions on various types. Just went with whatever to make progress.
I understand that
validatoris not probably the best terminology to use, especially when dealing with consensus stuff! :D Maybe an overloaded word...closes: #5315
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.