imp: deny selected client types from VerifyMembership rpc #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires #5870 to go first! |
damiannolan
requested review from
colin-axner and
AdityaSripal
as code owners
damiannolan
requested review from
crodriguezvega,
chatton,
DimitrisJim,
charleenfei and
srdtrk
Base automatically changed from
damian/5847-check-client-status-verifymembership-rpc
to
main
February 20, 2024 13:43
damiannolan
deleted the
damian/5848-disable-client-types-verifymembership-rpc
branch
mergify bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
* chore: add client status check to verify membership rpc * imp: deny selected client types from VerifyMembership rpc (cherry picked from commit 4f14cfd)
damiannolan
added a commit
that referenced
this pull request
Feb 20, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
* chore: add client status check to verify membership rpc * imp: deny selected client types from VerifyMembership rpc (cherry picked from commit 4f14cfd) # Conflicts: # modules/core/02-client/keeper/grpc_query.go # modules/core/02-client/keeper/grpc_query_test.go
crodriguezvega
pushed a commit
that referenced
this pull request
Feb 23, 2024
…5871) (#5885) * imp: deny selected client types from VerifyMembership rpc (#5871) * chore: add client status check to verify membership rpc * imp: deny selected client types from VerifyMembership rpc (cherry picked from commit 4f14cfd) # Conflicts: # modules/core/02-client/keeper/grpc_query.go # modules/core/02-client/keeper/grpc_query_test.go * fix conflicts * fix test --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
* chore: add client status check to verify membership rpc * imp: deny selected client types from VerifyMembership rpc (cherry picked from commit 4f14cfd) # Conflicts: # modules/core/02-client/keeper/grpc_query.go # modules/core/02-client/keeper/grpc_query_test.go
9 tasks
crodriguezvega
pushed a commit
that referenced
this pull request
Apr 8, 2024
) * chore: add client status check to verify membership rpc * imp: deny selected client types from VerifyMembership rpc (cherry picked from commit 4f14cfd) # Conflicts: # modules/core/02-client/keeper/grpc_query.go # modules/core/02-client/keeper/grpc_query_test.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deny
LocalhostandSolomachineclients fromVerifyMembershiprpc handlercloses: #5848
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.