-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable wasm lint/build/test on every PR and push to main. #5879
Conversation
wasm tests should still fail for time being. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we originally had this under stricter rules because the contract tests did not have the mock vm yet.
Thanks @DimitrisJim 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left once comment about (possibly) a redundant test run
push: | ||
branches: | ||
main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to run them again on merge to main? The code on the PR should already be synced with main when they're running on the PR right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea should be redundant, can't think of a case where it wouldn't (maybe auto merge?).
Looking at our other workflows (callbacks and main ibc-go one), we do run em in so I'll just push this with it for now and we can drop em all at some point.
Description
not running these could lead to subtle errors passing through with changes to ibc-go. Since we consume ibc-go as a library, it is a good idea to run these tests whenever it changes.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.