Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable wasm lint/build/test on every PR and push to main. #5879

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

DimitrisJim
Copy link
Contributor

Description

not running these could lead to subtle errors passing through with changes to ibc-go. Since we consume ibc-go as a library, it is a good idea to run these tests whenever it changes.

closes: #XXXX

Commit Message / Changelog Entry

ci: enable wasm lint/build/test on every PR and push to main.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor Author

wasm tests should still fail for time being.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we originally had this under stricter rules because the contract tests did not have the mock vm yet.

Thanks @DimitrisJim 👍🏻

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left once comment about (possibly) a redundant test run

Comment on lines +5 to +7
push:
branches:
main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to run them again on merge to main? The code on the PR should already be synced with main when they're running on the PR right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea should be redundant, can't think of a case where it wouldn't (maybe auto merge?).

Looking at our other workflows (callbacks and main ibc-go one), we do run em in so I'll just push this with it for now and we can drop em all at some point.

@DimitrisJim DimitrisJim merged commit 3fa025a into main Feb 21, 2024
69 checks passed
@DimitrisJim DimitrisJim deleted the jim/enable-wasm-tests branch February 21, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants