refactor: use local clock time only for transfer CLI relative timeouts #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disable relative timeouts by block height
…e transfer CLI inline comments
damiannolan
requested review from
colin-axner and
AdityaSripal
as code owners
damiannolan
commented
Feb 26, 2024
|
Published as r4r for e2es, and will manually test tomorrow morning 👍🏻 |
damiannolan
requested review from
crodriguezvega,
chatton,
DimitrisJim,
charleenfei and
srdtrk
…sistent for both height and timestamp timeouts
modules/apps/27-interchain-accounts/controller/client/cli/tx.go
Outdated
Show resolved
Hide resolved
DimitrisJim
reviewed
Feb 27, 2024
colin-axner
reviewed
Feb 27, 2024
damiannolan
requested review from
colin-axner,
DimitrisJim and
crodriguezvega
colin-axner
reviewed
Feb 28, 2024
| @@ -73,8 +82,8 @@ func newSendTxCmd() *cobra.Command { | |||
| Use: "send-tx [connection-id] [path/to/packet_msg.json]", | |||
| Short: "Send an interchain account tx on the provided connection.", | |||
| Long: strings.TrimSpace(`Submits pre-built packet data containing messages to be executed on the host chain | |||
| and attempts to send the packet. Packet data is provided as json, file or string. An | |||
| appropriate relative timeoutTimestamp must be provided with flag {relative-packet-timeout}`), | |||
| and attempts to send the packet. Packet data is provided as json, file or string. A relative timeout timestamp can be provided with flag {packet-timeout-timestamp}. | |||
There was a problem hiding this comment.
If it's correct that absolute timeout timestamps can be used when flagAbsoluteTimeouts is true and flagPacketTimeoutTimestamp is also set, should we update this doc string to clarify that? At the moment, the way it reads I think a reader would think flagPacketTimeoutTimestamp can only be used for relative timeouts...
There was a problem hiding this comment.
Updated in 7f673fb
feel free to push another commit if you want to change it.
colin-axner
approved these changes
Mar 4, 2024
chatton
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3594
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.