-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update project structure #5944
Conversation
WalkthroughThis update introduces a significant enhancement to the Cosmos SDK, focusing on dynamic capability storage and improved interaction mechanisms for IBC apps. By implementing ADR 003 and ADR 008, it adds a Changes
Related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/dev/project-structure.md (2 hunks)
Additional comments: 3
docs/dev/project-structure.md (3)
- 11-13: The description of the
capability
module is clear and effectively communicates its purpose and implementation basis on Cosmos SDK's ADR 003. Good job on providing the direct link to the ADR for further reading.- 29-29: The introduction of the
callbacks
module and its purpose, as outlined here, aligns well with the objectives of ADR 008. Including the module's documentation link provides a helpful resource for further exploration.- 35-36: The updates to the
light-clients
section, including the descriptions for08-wasm
and09-localhost
, are well-documented and align with the implementations for ICS 08 and ICS 09. These additions enhance the documentation's comprehensiveness regarding light client support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for remembering these often forgotten additions! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏻
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.Codecov Report
in the comment section below once CI passes.Summary by CodeRabbit
capability
module for dynamic capability store.callbacks
module for secondary applications to interact with IBC apps.light-clients
.