nit: rename currentChannel to channel
#5946
Conversation
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
|
Warning Rate Limit Exceeded@crodriguezvega has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 49 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent modifications involve improvements in the handling of channels and the management of consensus states within a blockchain framework. Specifically, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| @@ -268,6 +268,34 @@ func PruneAllExpiredConsensusStates( | |||
| return len(heights) | |||
| } | |||
|
|
|||
| func PruneAllConsensusStates( | |||
There was a problem hiding this comment.
shite, yes :(
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- modules/core/04-channel/keeper/events.go (9 hunks)
- modules/light-clients/07-tendermint/store.go (1 hunks)
Additional comments: 9
modules/core/04-channel/keeper/events.go (9)
- 275-286: The renaming of the variable from
currentChanneltochannelinEmitChannelUpgradeInitEventis consistent with the PR's objective. This change simplifies the naming without affecting the functionality. The use ofchannelas a parameter name is clear and concise, which improves readability.- 296-307: The renaming in
EmitChannelUpgradeTryEventfollows the same pattern as previously noted, maintaining consistency across event-emitting functions. The concise naming helps in understanding the function's purpose and parameters more easily.- 317-328: In
EmitChannelUpgradeAckEvent, the renaming is applied correctly. It's good to see consistency in naming conventions across different event-emitting functions, which contributes to a cleaner and more maintainable codebase.- 338-347:
EmitChannelUpgradeConfirmEventalso adheres to the renaming convention. Consistent naming across these functions not only simplifies the code but also aligns with Go's naming idioms.- 357-369: The changes in
EmitChannelUpgradeOpenEventare correctly implemented. The renaming here, as in other functions, aids in enhancing the clarity and maintainability of the code.- 379-392:
EmitChannelUpgradeTimeoutEventcorrectly implements the renaming. This consistency in variable naming across event-emitting functions is commendable and contributes to the overall readability of the code.- 402-410: In
EmitErrorReceiptEvent, the renaming is applied appropriately. This change, while minor, helps in maintaining a uniform naming convention throughout the file.- 421-432: The renaming in
EmitChannelUpgradeCancelEventis consistent with the PR's objectives. It's good to see uniformity in the approach to naming variables across different functions.- 442-450: The renaming in
emitChannelFlushCompleteEvent(note the lowercase 'e' in 'emit', indicating it's likely intended as a private function) is correctly implemented. This maintains the consistency of the renaming effort across the file.
nice try @coderabbitai but the truth is the function does not align with the PR's objective to improve code readability of channel upgradability related functions 😄 |
|
Tip For best results, initiate chat on the files or code changes. @colin-axner, thank you for the clarification! 😄 I see now that my interpretation missed the mark regarding the primary objective of the PR, which is to enhance code readability, especially around channel upgradability functions. The addition of |
🎤 💧 |
|
Tip For best results, initiate chat on the files or code changes. @chatton, point taken with style! 😄 Your mic drop moment underscores the importance of staying aligned with the PR's objectives. Thanks for keeping the conversation lively and insightful! 🎤💧 |
Description
I thought that
currentdidn't add any value, and I believe this could have been a leftover from where the first implementation of channel upgrades where the channel state needed to be reverted.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.Codecov Reportin the comment section below once CI passes.Summary by CodeRabbit
channelparameter for attribute values.