refactor: modify CheckMisbehaviourAndUpdateState to set client state #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the client state return value from CheckMisbehaviourAndUpdateState light clients are expected to set the client state in the client store after verifying misbehaviour fixed tests
Codecov Report
@@ Coverage Diff @@
## 02-client-refactor #595 +/- ##
======================================================
+ Coverage 79.85% 79.86% +0.01%
======================================================
Files 150 150
Lines 10803 10809 +6
======================================================
+ Hits 8627 8633 +6
Misses 1752 1752
Partials 424 424
|
colin-axner
changed the title
damiannolan
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
So CheckMisbehaviourAndUpdateState and VerifyUpgradeAndUpdateState were always supposed to update the client state but it was being done outside the scope of the functions?
So this just shifts the responsibility directly to the lightclient implementation as opposed to 02-client, is that correct? 🤔
colin-axner
requested review from
fedekunze,
crodriguezvega,
seantking and
charleenfei
as code owners
|
This function will be removed so these changes are unnecessary |
colin-axner
deleted the
colin/285-modify-checkmisbehaviourandupdatestate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the client state return value from CheckMisbehaviourAndUpdateState. Llight clients are expected to set the client state in the client store after verifying misbehaviour
closes: #285
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes