Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rpc VerifyMembershipProof - querier approach for conditional clients (backport #5821) #6105

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 8, 2024

Description

Adds the new Query service rpc VerifyMembershipProof outlined in #5310. Big thanks to @srdtrk for the initial deep dive on this issue.

closes: #5310


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

This is an automatic backport of pull request #5821 done by [Mergify](https://mergify.com).

…nal clients (#5821)

* feat: adding protobuf msgs and rpc for VerifyMembershipProof

* feat: adding VerifyMembershipProof query implementation and wiring

* chore(08-wasm): add VerifyMembershipProof to stargate query acceptlist

* test: adding failure case unit tests for VerifyMembershipProof query

* fix: correct protodoc

* chore: proto-swagger-gen

* chore: protodocs

* test: adding additional test cases

* test: assert gas consumed in tests

* chore: rename rpc to VerifyMembership and update tests

* chore: update service definition URL in 08-wasm stargate accepted queries

* test: adding verify membership test to 08-wasm querier

* Update proto/ibc/core/client/v1/query.proto

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* chore: review items - log error at debug, pass cachedCtx and adjust tests for discarded state checks

* chore: add doc comment to querier test, address nit to move defaultAcceptList

* chore: regen protos and swagger doc

* nit: update comment in querier

* imp: add more info to godoc for VerifyMembership rpc

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Cian Hatton <cian@interchain.io>
(cherry picked from commit ed9bf74)

# Conflicts:
#	docs/client/swagger-ui/swagger.yaml
#	modules/light-clients/08-wasm/types/querier.go
#	modules/light-clients/08-wasm/types/querier_test.go
Copy link
Contributor Author

mergify bot commented Apr 8, 2024

Cherry-pick of ed9bf74 has failed:

On branch mergify/bp/release/v8.3.x/pr-5821
Your branch is up to date with 'origin/release/v8.3.x'.

You are currently cherry-picking commit ed9bf74c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/02-client/keeper/grpc_query.go
	modified:   modules/core/02-client/keeper/grpc_query_test.go
	modified:   modules/core/02-client/types/query.pb.go
	modified:   modules/core/02-client/types/query.pb.gw.go
	modified:   modules/core/keeper/grpc_query.go
	modified:   proto/ibc/core/client/v1/query.proto

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/client/swagger-ui/swagger.yaml
	deleted by us:   modules/light-clients/08-wasm/types/querier.go
	deleted by us:   modules/light-clients/08-wasm/types/querier_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

coderabbitai bot commented Apr 8, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@crodriguezvega crodriguezvega self-assigned this Apr 8, 2024
@damiannolan damiannolan merged commit 2d60802 into release/v8.3.x Apr 8, 2024
19 checks passed
@damiannolan damiannolan deleted the mergify/bp/release/v8.3.x/pr-5821 branch April 8, 2024 11:58
@DimitrisJim
Copy link
Contributor

this could do with a changelog entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants