Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ConsensusHost interface for custom self client/consensus state validation (backport #6055) #6111

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 8, 2024

Description

Co-authored-by: chatton github.qpeyb@simplelogin.fr

Adds the ConsensusHost interface type to 02-client as well as implementation for 07-tendermint and 08-wasm.

closes: #5315


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

  • New Features
    • Improved blockchain interoperability by introducing a WasmConsensusHost struct for wasm-wrapped consensus in the IBC package.
  • Tests
    • Ensured reliability and robustness through extensive testing of the new wasm consensus mechanism in diverse scenarios.

This is an automatic backport of pull request #6055 done by [Mergify](https://mergify.com).

…us state validation (#6055)

Co-authored-by: chatton <github.qpeyb@simplelogin.fr>
(cherry picked from commit 50d2a08)

# Conflicts:
#	CHANGELOG.md
#	modules/core/02-client/keeper/keeper.go
#	modules/core/02-client/keeper/keeper_test.go
#	modules/core/02-client/types/errors.go
#	modules/light-clients/08-wasm/testing/simapp/app.go
Copy link
Contributor Author

mergify bot commented Apr 8, 2024

Cherry-pick of 50d2a08 has failed:

On branch mergify/bp/release/v8.3.x/pr-6055
Your branch is up to date with 'origin/release/v8.3.x'.

You are currently cherry-picking commit 50d2a087.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/02-client/abci.go
	modified:   modules/core/02-client/keeper/migrations.go
	modified:   modules/core/02-client/migrations/v7/genesis_test.go
	modified:   modules/core/02-client/proposal_handler.go
	modified:   modules/core/02-client/types/client.go
	modified:   modules/core/02-client/types/genesis_test.go
	modified:   modules/core/03-connection/keeper/handshake_test.go
	modified:   modules/core/genesis.go
	modified:   modules/core/keeper/keeper.go
	deleted:    modules/core/keeper/migrations.go
	modified:   modules/core/migrations/v7/genesis_test.go
	new file:   modules/light-clients/07-tendermint/consensus_host.go
	new file:   modules/light-clients/07-tendermint/consensus_host_test.go
	new file:   modules/light-clients/08-wasm/types/consensus_host.go
	new file:   modules/light-clients/08-wasm/types/consensus_host_test.go
	new file:   testing/mock/consensus_host.go
	modified:   testing/simapp/upgrades.go
	modified:   testing/simapp/upgrades/upgrades.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   modules/core/02-client/keeper/keeper.go
	both modified:   modules/core/02-client/keeper/keeper_test.go
	both modified:   modules/core/02-client/types/errors.go
	deleted by us:   modules/light-clients/08-wasm/testing/simapp/app.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

coderabbitai bot commented Apr 8, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@damiannolan damiannolan self-assigned this Apr 8, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Apr 9, 2024
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the effort to make it not API breaking. 🙏

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, think we landed on a solid non-api breaking solution 🥇

@damiannolan damiannolan merged commit 98674c7 into release/v8.3.x Apr 10, 2024
19 checks passed
@damiannolan damiannolan deleted the mergify/bp/release/v8.3.x/pr-6055 branch April 10, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants