Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e cleanup #6145

Merged
merged 3 commits into from
Apr 12, 2024
Merged

e2e cleanup #6145

merged 3 commits into from
Apr 12, 2024

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Apr 11, 2024

Description

Unreleased compatibility tests passed from this branch here.
Compatibility tests for v8.2.x here (failures should be fixed with #6142)

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated compatibility test matrices by removing outdated versions and retaining current stable versions across various chains.
    • Adjusted automation rules to focus on current and upcoming release branches, enhancing maintenance efficiency.

Copy link
Contributor

coderabbitai bot commented Apr 11, 2024

Walkthrough

Walkthrough

The recent changes involve a systematic update to various JSON configuration files related to compatibility testing matrices for different chains. The focus was on removing outdated software versions and incorporating new versions to enhance testing efficiency and accuracy across different chains.

Changes

File Path Change Summary
.github/compatibility-test-matrices/main/...
.github/compatibility-test-matrices/release-v7.4.x/...
.github/compatibility-test-matrices/release-v8.2.x/...
Updated versions in compatibility test matrices, removing older versions like v8.1.0, v8.0.1, etc., and adding newer versions such as v6.3.0, v5.4.0, etc. across various chains.
.github/mergify.yml Removed backport rules for specific branches (v7.2.x, v7.3.x, v8.0.x, v8.1.x) while retaining rules for v7.4.x, v7.5.x, and v8.2.x branches.

Possibly related issues

  • Automate generation of compatibility json files #4872: This issue aligns with the changes made in this PR by focusing on automating the generation of compatibility JSON files and maintaining a structured versioning system. The PR's updates to the compatibility matrices and workflows could support the objectives outlined in this issue.

Recent Review Details

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between caf4208 and 3d41221.
Files selected for processing (1)
  • .github/mergify.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/mergify.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment on lines +8 to +12
"v6.3.0",
"v5.4.0",
"v4.6.0",
"v3.4.0",
"v2.5.0",
Copy link
Contributor Author

@crodriguezvega crodriguezvega Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added here the latest tags for the previous releases that are already EoL (except v1, for which there is no docker image). I think this is good to do, even if those release lines are not supported anymore, just to make sure that we keep backwards compatibility, but I am open to hear everyone's thoughts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's strictly necessary but it's no harm, especially since some of these versions are still in use.

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for cleaning up these matricies 🥇

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks for taking care of these! 🚀

@crodriguezvega crodriguezvega merged commit fc5dbed into main Apr 12, 2024
370 checks passed
@crodriguezvega crodriguezvega deleted the carlos/e2e-cleanup branch April 12, 2024 10:40
bznein pushed a commit to bznein/ibc-go that referenced this pull request Apr 12, 2024
* chores: cleanup e2e

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants