test: fix grandpa e2e tests

[hoank101]

Description

closes: #6243

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/).
• Added relevant godoc comments.
• Provide a conventional commit message to follow the repository standards.
• Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
• Re-reviewed Files changed in the GitHub PR explorer.
• Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

• Refactor
  • Updated the method of fetching IBC balance in the Grandpa test suite to use a more formatted address representation.

[coderabbitai]

Walkthrough

Walkthrough

The update in grandpa_test.go involves refining the address formatting in the GetIbcBalance function call within the GrandpaTestSuite. This change enhances code readability and potentially the handling of user addresses by standardizing the format used across test cases.

Changes

File Path	Change Summary
.../grandpa_test.go	Updated address formatting in GetIbcBalance function

Assessment against linked issues

Objective	Addressed	Explanation
Refactor Grandpa Test IBC Transfer to use suite.Transfer (#4963)	❌	The change does not involve refactoring to use suite.Transfer.
Clean up the denom specification in the TestMsgTransfer_Succeeds_GrandpaContract test (#4964)	❌	No changes related to denom specifications were made.

Possibly related issues

• Issue Refactor Grandpa Test IBC Transfer to use suite.Transfer #4963: Although the current PR does not refactor the test to use suite.Transfer, it does involve a related area (IBC transfers in tests), suggesting a potential overlap in context.
• Issue Clean up denom specified in TestMsgTransfer_Succeeds_GrandpaContract #4964: This issue focuses on cleanup within the same test function that was modified in the PR, indicating that any further refactoring or cleanup efforts might need to consider these changes for consistency.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f02df5 and f12fccd.

Files selected for processing (1)

• e2e/tests/wasm/grandpa_test.go (1 hunks)

Files not reviewed due to errors (1)

• e2e/tests/wasm/grandpa_test.go (no review received)

Additional Context Used

Path-based Instructions (1)

e2e/tests/wasm/grandpa_test.go (3)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

---

Pattern e2e/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

---

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

[crodriguezvega]

Thank you, @hoank101. @damiannolan tracked down the root issue of the failures. For now we will just disable the tests.