tests(e2e): ics20 v2 multidenom #6290

crodriguezvega · 2024-05-10T14:41:25Z

Description

TestMsgTransfer_Succeeds_Nonincentivized_MultiDenom
TestMsgTransfer_Fails_InvalidAddress_MultiDenom
TestChannelUpgrade_WithICS20v2_Succeeds
TestChannelUpgrade_WithFeeMiddlewareAndICS20v2_Succeeds
TestChannelDowngrade_WithICS20v1_Succeeds

closes: #6469

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

* chore: adding proto files for ics20-v2 * chore: add newline

* add CurrentVersion, EscrowVersion, update tests * update hardcoded transfer channel version from interchaintest

--------- Co-authored-by: Charly <charly@interchain.berlin>

…ods (#6126)

…shalling/conversion (#6226) * chore: adding proto files for ics20-v2 * chore: add newline * chore: modify MsgTransfer to accept coins instead of coin * chore: reverted unintentional comment changes * chore: reverted unintentional comment changes * chore: adding test for conversion fn * chore: fix e2e linter * chore: adding docs * chore: addressing PR feedback * chore: remove duplicate import * chore: addressing PR feedback * chore: moved extration logic into internal package * chore: commented out failing test * chore: adding link to issue * chore: remove duplicate import * chore: fix linting errors * FungibleTokenPacketData interface methods + tests * linter * wip: token validation * update trace identifier validation in Token + tests * rm Printf * update with pr review * add CurrentVersion, EscrowVersion, update tests * pr review * fix e2e tests * pr review * update e2e test version * linter * update hardcoded transfer channel version from interchaintest * update hardcoded transfer channel version from interchaintest * wip packet unmarshaller * wip * wip testing * update test * linter * rm unnecessary version changes * rm unnecessary artifacts * update callbacks test * update comment * pr review * rename getMultiDenomFungibleTokenPacketData to unmarshalPacketDataBytesToICS20V2 --------- Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

…allbacks (#6175) * add SupportedVersions array for different ics20 versions, add version checking on channel handshake application callbacks * add tests * update pr review * pr review * last few pr review nits * linter * add version counter proposing * fix missing app versino * update code + tests to return our proposed version if counterparty version is invalid * remove if statement * address review comments: return ics20-2 if counterparty version is not supported --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

…transfers (#6252) * add transfer authz code + tests * linter * address review comments --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

…ks (#6189) * chore: adding proto files for ics20-v2 * chore: add newline * chore: modify MsgTransfer to accept coins instead of coin * chore: reverted unintentional comment changes * chore: reverted unintentional comment changes * chore: adding test for conversion fn * chore: fix e2e linter * chore: adding docs * chore: addressing PR feedback * chore: remove duplicate import * chore: addressing PR feedback * chore: moved extration logic into internal package * chore: commented out failing test * chore: adding link to issue * chore: remove duplicate import * chore: fix linting errors * FungibleTokenPacketData interface methods + tests * linter * wip: token validation * update trace identifier validation in Token + tests * rm Printf * update with pr review * pr review * linter * rm unused function: linter * wip pr feedback * fix test * pr review * lintttttt * wip: backwards compatibility for transfer rpc * implement changes for ics20-v2 packet data for onRecvPacket, onAcknowledgePacket and onTimeoutPacket * fix callbacks tests * lint --------- Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: Charly <charly@interchain.berlin>

coderabbitai · 2024-05-10T14:41:30Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

# Conflicts: # e2e/tests/core/02-client/client_test.go # e2e/tests/core/03-connection/connection_test.go # e2e/tests/transfer/base_test.go # e2e/tests/transfer/localhost_test.go # e2e/tests/transfer/upgrades_test.go # e2e/tests/upgrades/genesis_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/testsuite.go # e2e/testsuite/tx.go

crodriguezvega · 2024-06-10T07:02:23Z

e2e/tests/transfer/upgrades_test.go

+}
+
+// TestChannelDowngrade_WithICS20v1_Succeeds tests downgrading a transfer channel from ICS20 v2 to ICS20 v1.
+func (s *TransferChannelUpgradesTestSuite) TestChannelDowngrade_WithICS20v1_Succeeds() {


If people think is worth it, I can add a another test to downgrade from fee middleware + ICS2 v2 to ICS20 v1.

DimitrisJim · 2024-06-11T11:16:50Z

e2e/tests/transfer/base_test.go

+
+	s.Require().NoError(test.WaitForBlocks(ctx, 5, chainA, chainB), "failed to wait for blocks")
+
+	t.Run("native chainB tokens are escrowed", func(t *testing.T) {


def seems like a race condition that could lead to flakyness, why can't this be placed right after the s.AssertTxSuccess call on line 322?

I think it's to wait on the relayer. When you s.StartRelayer that blocks on clearing all packets, but as the relayer is already started, we need some wait condition. I think the quick trick is to wait on blocks. There's probably an issue somewhere to wait on the relayer

Look at that #1981

but is this needed to query the balance on chain B right after the msg transfer is submitted to it? this should be query-able right after the tx succeeds? waiting for blocks means that this query might happen right after the tokens are returned to sender hence failing the assertion on lin 332?

looks like if we are checking the escrow amounts, the wait for block could actually be moved down

yup! think that would take care of failure in this test.

colin-axner · 2024-06-12T14:05:27Z

e2e/tests/transfer/base_test.go

+	s.Require().NoError(test.WaitForBlocks(ctx, 5, chainA, chainB), "failed to wait for blocks")
+
+	t.Run("native chainA tokens are escrowed", func(t *testing.T) {
+		actualBalance, err := s.GetChainANativeBalance(ctx, chainAWallet)


food for thought: I feel like there's a lot of repeated code in our e2e's. Would cut down review time on new pr's if we deduplicated this

On my list of ideas for a focus week 👀

colin-axner

Thanks @crodriguezvega! Great that all these test cases could be written in such a straightforward manner. Excellent work 👏

colin-axner · 2024-06-12T14:07:53Z

e2e/tests/transfer/upgrades_test.go

+	})
+
+	t.Run("tokens are un-escrowed", func(t *testing.T) {
+		actualTotalEscrow, err := query.TotalEscrowForDenom(ctx, chainA, chainADenom)


should we check total escrow of the second token?

chatton

These tests look amazing @crodriguezvega great job!

Definitely agree with @colin-axner and think we should probably spend some time de-duplicating these tests.

Left a couple small nits but nothing blocking 🚀

chatton · 2024-06-17T12:10:42Z

e2e/tests/transfer/base_test.go

+	chainAIBCToken := testsuite.GetIBCToken(chainBDenom, channelA.PortID, channelA.ChannelID)
+
+	t.Run("native IBC token transfer from chainA to chainB, sender is source of tokens", func(t *testing.T) {
+		transferTxResp := s.Transfer(ctx, chainA, chainAWallet, channelA.PortID, channelA.ChannelID, sdk.NewCoins(testvalues.DefaultTransferAmount(chainADenom)), chainAAddress, chainBAddress, s.GetTimeoutHeight(ctx, chainB), 0, "")


[nit] there is a testvaluesDefaultTransferCoins fn that does this sdk.NewCoins call to reduce boilerplate.

Happy to do this, but I prefer to do it in a separate PR, since there is already a bunch of places that could benefit from that.

chatton · 2024-06-17T12:11:24Z

e2e/tests/transfer/base_test.go

+	s.Require().NoError(test.WaitForBlocks(ctx, 5, chainA, chainB), "failed to wait for blocks")
+
+	t.Run("native chainA tokens are escrowed", func(t *testing.T) {
+		actualBalance, err := s.GetChainANativeBalance(ctx, chainAWallet)


On my list of ideas for a focus week 👀

chatton · 2024-06-17T12:16:14Z

e2e/tests/transfer/base_test.go

+	denoms := []string{chainBIBCToken.IBCDenom(), chainBDenom}
+	var transferCoins []sdk.Coin
+	for _, denom := range denoms {
+		transferCoins = append(transferCoins, testvalues.DefaultTransferAmount(denom))
+	}


[nit] with just two items it might be more readable to just do 2 appends instead of a for loop

chatton · 2024-06-17T12:23:54Z

e2e/tests/transfer/upgrades_test.go

+	ctx := context.TODO()
+
+	relayer, channelA := s.SetupChainsRelayerAndChannel(ctx, func(opts *ibc.CreateChannelOptions) {
+		opts.Version = transfertypes.V1


[nit] this is the only required change, happy to leave it all in if you want to be explicit

chatton · 2024-06-17T12:25:37Z

e2e/tests/transfer/upgrades_test.go

+		transferTxResp, err := chainA.SendIBCTransfer(ctx, channelA.ChannelID, chainAWallet.KeyName(), chainBWalletAmount, ibc.TransferOptions{})
+		s.Require().NoError(err)


this ends up using the cli, is there a reason not to use s.Transfer to broadcast a MsgTransfer directly?

No particular reason, but I will address this together with the other places in tests where we still call the CLI to do everything in one sweep.

sonarcloud · 2024-06-17T14:06:18Z

Quality Gate passed for 'ibc-go'

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

* Adding proto files for ics20-v2 (#6110) * chore: adding proto files for ics20-v2 * chore: add newline * update amount -> string (#6120) * Update MsgTransfer to accept sdk.Coins instead of sdk.Coin (#6113) * fix: allow base denom with trailing slash (#6148) * imp: add CurrentVersion, EscrowVersion (#6160) * add CurrentVersion, EscrowVersion, update tests * update hardcoded transfer channel version from interchaintest * chore: add function for converting packet data from v1 to v3 (#6116) --------- Co-authored-by: Charly <charly@interchain.berlin> * chore: implement required `FungibleTokenPacketData` v3 interface methods (#6126) * imp: `getMultiDenomFungibleTokenPacketData`to be used in packet unmarshalling/conversion (#6226) * chore: adding proto files for ics20-v2 * chore: add newline * chore: modify MsgTransfer to accept coins instead of coin * chore: reverted unintentional comment changes * chore: reverted unintentional comment changes * chore: adding test for conversion fn * chore: fix e2e linter * chore: adding docs * chore: addressing PR feedback * chore: remove duplicate import * chore: addressing PR feedback * chore: moved extration logic into internal package * chore: commented out failing test * chore: adding link to issue * chore: remove duplicate import * chore: fix linting errors * FungibleTokenPacketData interface methods + tests * linter * wip: token validation * update trace identifier validation in Token + tests * rm Printf * update with pr review * add CurrentVersion, EscrowVersion, update tests * pr review * fix e2e tests * pr review * update e2e test version * linter * update hardcoded transfer channel version from interchaintest * update hardcoded transfer channel version from interchaintest * wip packet unmarshaller * wip * wip testing * update test * linter * rm unnecessary version changes * rm unnecessary artifacts * update callbacks test * update comment * pr review * rename getMultiDenomFungibleTokenPacketData to unmarshalPacketDataBytesToICS20V2 --------- Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * chore: implement version checking for channel handshake application callbacks (#6175) * add SupportedVersions array for different ics20 versions, add version checking on channel handshake application callbacks * add tests * update pr review * pr review * last few pr review nits * linter * add version counter proposing * fix missing app versino * update code + tests to return our proposed version if counterparty version is invalid * remove if statement * address review comments: return ics20-2 if counterparty version is not supported --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * imp: update transfer authz implementation to account for multi denom transfers (#6252) * add transfer authz code + tests * linter * address review comments --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * ics20-v2: backwards compatibility for transfer rpc and packet callbacks (#6189) * chore: adding proto files for ics20-v2 * chore: add newline * chore: modify MsgTransfer to accept coins instead of coin * chore: reverted unintentional comment changes * chore: reverted unintentional comment changes * chore: adding test for conversion fn * chore: fix e2e linter * chore: adding docs * chore: addressing PR feedback * chore: remove duplicate import * chore: addressing PR feedback * chore: moved extration logic into internal package * chore: commented out failing test * chore: adding link to issue * chore: remove duplicate import * chore: fix linting errors * FungibleTokenPacketData interface methods + tests * linter * wip: token validation * update trace identifier validation in Token + tests * rm Printf * update with pr review * pr review * linter * rm unused function: linter * wip pr feedback * fix test * pr review * lintttttt * wip: backwards compatibility for transfer rpc * implement changes for ics20-v2 packet data for onRecvPacket, onAcknowledgePacket and onTimeoutPacket * fix callbacks tests * lint --------- Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: Charly <charly@interchain.berlin> * multidenom transfer test + ics20-v2 channel upgrade test * some fixes * changes to transfer tx CLI to support multiple denoms * lint * import renaming * Use type with V2 suffix for package data (#6330) * Adding additional comments and changing version variable names (#6345) * chore: correctly claim capability * lint * imp: change ics20 events to emit token set (#6348) * refactor: quick change to tokens event attribute * fix: various tests * lint * lint:fixeroni * imp: remove events variable in favour of direct event emission --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * imp: check length tokens array against maximum allowed (#6349) * check length of tokens array against maximum allowed * chore: add note on arbitrary selection --------- Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com> * Modify UnmarshalPacketData interface to allow additional args (#6341) * api(port)!: Allow passing of context, port and channel identifier to unmarshal packet data interface as disussed. This allows us to grab the app version in transfer and unmarshal the packet based on that instead of a hacky unmarshal v2 then v1 and whatever happens. * lint: as we do * callbacks: fix signature of UnmarshalPacketData as per changes, make refactors to hopefully simplify signatures. * chore: lint and remove some todos. * review: address feedback. * Refactor packet data unmarshalling to use specific version (#6354) * chore: specifically unmarshal v1 or v2 without brute force * chore: fix TestPacketDataUnmarshalerInterface test in transfer module * Pass dest values OnRecv, refactor GetExpectedEvents * chore: fixing TestGetCallbackData test * chore: fixed remaining tests in callbacks module * test: simplify callbacks test, revert back to previous behaviour * chore: fix test case name * chore: addressing PR feedback * chore: added docstring for unmarshalPacketDataBytesToICS20V2 --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com> * chore: fixing tests * imp: self review comments for ics20-v2 (#6360) * refactor: address various self review comments * revert: unnecessary change * lint * imp: self review on ics20-v2 part 2 (#6364) * refactor: apply review suggestions * imp: additional updates * refactor: make ValidateIBCDenom private * Update modules/apps/transfer/types/msgs.go Co-authored-by: Cian Hatton <cian@interchain.io> * apply review suggestions --------- Co-authored-by: Cian Hatton <cian@interchain.io> * chore: move functions from internal/denom back to trace.go (#6368) * chore: move functions from internal/denom to trace.go * lint * lint: the comeback * imp: ics20 v2 self review part 3 (#6373) * imp: self review items * apply jim's suggestion * Update modules/apps/transfer/keeper/msg_server_test.go * Update modules/apps/transfer/ibc_module.go * Update modules/apps/transfer/ibc_module.go * chore: remove duplicate test case * chore: address minor nits (#6374) * Refactor msgs_test.go to use expError (#6367) * chore: refactoring msgs_test.go to use expError * chore: updating expected errors * chore: update MsgUpdateParams and lint --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * chore: remove unused chain variable in setup (#6371) * use new queries in e2e * add test for error ack multidenom transfer * downgrade test to ics20-1 * add test to upgrade channel to fee middleware and ICS20 v2 * revert some unnecessary changes * add transfer failure multidenom test to compatibility * updates to multidenom invalid adress test * fix value comparison * review comments --------- Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Charly <charly@interchain.io> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

chatton and others added 12 commits April 8, 2024 13:00

Adding proto files for ics20-v2 (#6110)

c07bca9

* chore: adding proto files for ics20-v2 * chore: add newline

update amount -> string (#6120)

e66bd89

Update MsgTransfer to accept sdk.Coins instead of sdk.Coin (#6113)

034f472

fix: allow base denom with trailing slash (#6148)

4cc6a85

imp: add CurrentVersion, EscrowVersion (#6160)

71f830c

* add CurrentVersion, EscrowVersion, update tests * update hardcoded transfer channel version from interchaintest

chore: add function for converting packet data from v1 to v3 (#6116)

28ff9b6

--------- Co-authored-by: Charly <charly@interchain.berlin>

chore: implement required FungibleTokenPacketData v3 interface meth…

4e55137

…ods (#6126)

imp: update transfer authz implementation to account for multi denom …

9bbfa1a

…transfers (#6252) * add transfer authz code + tests * linter * address review comments --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

multidenom transfer test + ics20-v2 channel upgrade test

b4244f9

crodriguezvega requested review from colin-axner, AdityaSripal, charleenfei, damiannolan, chatton and DimitrisJim as code owners May 10, 2024 14:41

some fixes

b09f5d7

crodriguezvega marked this pull request as draft May 12, 2024 19:05

crodriguezvega changed the title ~~WiP - tests(e2e): ics20 v2 multidenom~~ tests(e2e): ics20 v2 multidenom May 12, 2024

crodriguezvega and others added 8 commits May 14, 2024 10:50

changes to transfer tx CLI to support multiple denoms

4c333c5

lint

8b55295

import renaming

0478cb9

Use type with V2 suffix for package data (#6330)

f39d173

Adding additional comments and changing version variable names (#6345)

9b39944

Merge branch 'main' into merge-main

06ca9a5

chore: correctly claim capability

7897ef3

lint

786a4f1

crodriguezvega added 3 commits June 7, 2024 22:08

downgrade test to ics20-1

6886e3b

add test to upgrade channel to fee middleware and ICS20 v2

14d17ff

crodriguezvega marked this pull request as ready for review June 9, 2024 18:25

crodriguezvega requested a review from gjermundgaraba as a code owner June 9, 2024 18:25

crodriguezvega added the priority PRs that need prompt reviews label Jun 9, 2024

crodriguezvega commented Jun 10, 2024

View reviewed changes

crodriguezvega added 3 commits June 10, 2024 09:02

revert some unnecessary changes

3f12a8e

add transfer failure multidenom test to compatibility

087d52f

Merge branch 'main' into carlos/e2e-tests-multidenom

feb2383

gjermundgaraba approved these changes Jun 10, 2024

View reviewed changes

DimitrisJim reviewed Jun 11, 2024

View reviewed changes

colin-axner reviewed Jun 12, 2024

View reviewed changes

colin-axner approved these changes Jun 12, 2024

View reviewed changes

updates to multidenom invalid adress test

bdd4ab6

crodriguezvega requested a review from bznein as a code owner June 17, 2024 07:37

crodriguezvega added 2 commits June 17, 2024 09:51

Merge branch 'main' into carlos/e2e-tests-multidenom

70f9b8c

fix value comparison

7d42ff3

chatton approved these changes Jun 17, 2024

View reviewed changes

crodriguezvega added 2 commits June 17, 2024 15:40

review comments

d4bd933

Merge branch 'main' into carlos/e2e-tests-multidenom

fbb6994

crodriguezvega added this pull request to the merge queue Jun 17, 2024

Merged via the queue into main with commit 99f3814 Jun 17, 2024
83 of 84 checks passed

crodriguezvega deleted the carlos/e2e-tests-multidenom branch June 17, 2024 18:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests(e2e): ics20 v2 multidenom #6290

tests(e2e): ics20 v2 multidenom #6290

crodriguezvega commented May 10, 2024 •

edited

Loading

coderabbitai bot commented May 10, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

crodriguezvega Jun 10, 2024

DimitrisJim Jun 11, 2024 •

edited

Loading

colin-axner Jun 12, 2024

colin-axner Jun 12, 2024

DimitrisJim Jun 12, 2024

colin-axner Jun 12, 2024

DimitrisJim Jun 12, 2024

colin-axner Jun 12, 2024

chatton Jun 17, 2024

colin-axner left a comment

colin-axner Jun 12, 2024

chatton left a comment

chatton Jun 17, 2024

crodriguezvega Jun 17, 2024

chatton Jun 17, 2024

chatton Jun 17, 2024

chatton Jun 17, 2024

chatton Jun 17, 2024

crodriguezvega Jun 17, 2024 •

edited

Loading

sonarcloud bot commented Jun 17, 2024


		s.Require().NoError(test.WaitForBlocks(ctx, 5, chainA, chainB), "failed to wait for blocks")

		t.Run("native chainB tokens are escrowed", func(t *testing.T) {

		transferTxResp, err := chainA.SendIBCTransfer(ctx, channelA.ChannelID, chainAWallet.KeyName(), chainBWalletAmount, ibc.TransferOptions{})
		s.Require().NoError(err)

tests(e2e): ics20 v2 multidenom #6290

tests(e2e): ics20 v2 multidenom #6290

Conversation

crodriguezvega commented May 10, 2024 • edited Loading

Description

coderabbitai bot commented May 10, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

DimitrisJim Jun 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colin-axner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chatton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crodriguezvega Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Jun 17, 2024

Quality Gate passed for 'ibc-go'

crodriguezvega commented May 10, 2024 •

edited

Loading

coderabbitai bot commented May 10, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

DimitrisJim Jun 11, 2024 •

edited

Loading

crodriguezvega Jun 17, 2024 •

edited

Loading