-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: add updateClientCheckTx to redunant relayer ante decorator (backport #6279) #6304
imp: add updateClientCheckTx to redunant relayer ante decorator (backport #6279) #6304
Conversation
* imp: add checkTxUpdateClient to redunant relayer ante decorator * chore: update godoc and duplicate imports * test: add coverage for checkTxUpdateClient func * chore: rename ante func to updateClientCheckTx (cherry picked from commit 3da4830) # Conflicts: # modules/core/ante/ante.go # modules/core/ante/ante_test.go
Cherry-pick of 3da4830 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review SkippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Due to #6313 we should implement same solution as v7.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
switch clientMsg.(type) { | ||
case *solomachine.Misbehaviour: | ||
// ignore solomachine misbehaviour for update state in ante | ||
case *tendermint.Misbehaviour: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically not necessary, but happy to leave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Epic!
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Description
Adds
checkTxUpdateClient
to ante decorator.ref: #6232
Can be released as patch on v7.5.x and v8.3.x but requires additional changes for patching on earlier releases
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.Summary by CodeRabbit
New Features
Refactor
This is an automatic backport of pull request #6279 done by [Mergify](https://mergify.com).