-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add merge_group tag to all required workflows. #6540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to testing this! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to test this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add this for e2e jobs? Or are we happy running e2e's once before adding to merge group?
I think running once is fine..?
Can you give a brief description of exactly what merge_group
does?
its an event trigger like merging so we can enable them from settings, lmk from chat if you think we should add e2e's or anything else that comes to mind. |
Description
This adds the merge group tag to the required workflows in order to not stall on merge (by not triggering the required ones).
Do we want to add this for e2e jobs? Or are we happy running e2e's once before adding to merge group?
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.