Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add merge_group tag to all required workflows. #6540

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

DimitrisJim
Copy link
Contributor

Description

This adds the merge group tag to the required workflows in order to not stall on merge (by not triggering the required ones).

Do we want to add this for e2e jobs? Or are we happy running e2e's once before adding to merge group?


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim added the github_actions Pull requests that update Github_actions code label Jun 7, 2024
@crodriguezvega crodriguezvega added the type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation label Jun 7, 2024
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to testing this! 🚀

Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to test this!

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add this for e2e jobs? Or are we happy running e2e's once before adding to merge group?

I think running once is fine..?

Can you give a brief description of exactly what merge_group does?

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Jun 10, 2024

Can you give a brief description of exactly what merge_group does?

its an event trigger like push, pull_request etc, basic gist as I've understood is github adds these to merge queue, triggers that event and runs tests and then does the merge for you (instead of us competing for it). Next in line gets brought up to speed and cycle goes again.

merging so we can enable them from settings, lmk from chat if you think we should add e2e's or anything else that comes to mind.

@DimitrisJim DimitrisJim merged commit 8caf237 into main Jun 10, 2024
82 checks passed
@DimitrisJim DimitrisJim deleted the jim/merge-group-tag branch June 10, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants