imp: adding 08-wasm build opts with libwasmvm linking disabled (backport #5923)

[mergify]

Description

Tested adding custom build directive nolink_libwasmvm in rollkit app binary compilation.
See: chatton/gm-demo#2 (with successful build discarding libwasmvm dependencies - NOTE: uses fork of wasmvm with build directives)

panic: not implemented, please build with cgo enabled or nolink_libwasmvm disabled

goroutine 1 [running]:
github.com/cosmos/ibc-go/modules/light-clients/08-wasm/keeper.NewKeeperWithVM(...)
        github.com/cosmos/ibc-go/modules/light-clients/08-wasm@v0.0.0-20240320102325-afd056184d7e/keeper/keeper_no_vm.go:27
gm/app.RegisterIBC({0x10f524678, 0xc0004a2000})
        gm/app/ibc.go:222 +0x50b
gm/cmd/gmd/cmd.NewRootCmd()
        gm/cmd/gmd/cmd/root.go:110 +0x3d7
main.main()
        gm/cmd/gmd/main.go:14 +0x17

When the application binary is compiled removing the calls to wasmkeeper.NewKeeperWithVM and wasmkeeper.NewKeeperWithConfig the docker image can be run and the entrypoint executes successfully returning the simd help text.

closes: #5903

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

• New Features

  • Introduced a Docker build target for WebAssembly simulation applications.
  • Enhanced the Wasm module by integrating WebAssembly VM functionality for better interface and management within Cosmos SDK applications.
  • Added documentation on configuring the Wasm module for different operational modes, including options to disable CGO or selectively link with libwasmvm.

• Refactor

  • Streamlined Keeper initialization in the Wasm module by consolidating logic into a single struct initialization approach.
  • Removed redundant interface declaration in the Wasm engine code to simplify interface definitions.

• Chores

  • Updated the Makefile to include a new build target and improved the help target output.

---

This is an automatic backport of pull request #5923 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 031c2b8 has failed:

On branch mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x/pr-5923
Your branch is up to date with 'origin/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x'.

You are currently cherry-picking commit 031c2b83.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/light-clients/08-wasm/doc.go
	modified:   modules/light-clients/08-wasm/internal/ibcwasm/expected_interfaces.go
	new file:   modules/light-clients/08-wasm/internal/ibcwasm/wasm_vm.go
	new file:   modules/light-clients/08-wasm/keeper/keeper_no_vm.go
	new file:   modules/light-clients/08-wasm/keeper/keeper_vm.go
	new file:   scripts/build-wasm-simapp-docker.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Makefile
	both modified:   modules/light-clients/08-wasm/keeper/keeper.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[damiannolan]

waiting on #6563