-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete forwarded packet when it is not needed anymore #6621
Merged
bznein
merged 40 commits into
feat/ics20-v2-path-forwarding
from
bznein/6546/deletepacket
Jun 21, 2024
Merged
Changes from 5 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
013f883
Create ontimeoutpacket test for forwarding
bznein 83f4582
Propagate ack on A
bznein 59b93ed
Refactoring
bznein ff35ada
Minor changes
bznein 926d8da
Added comments
bznein 8a3dd36
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6384/ontimeo…
bznein 3f5dc6c
Fix type name.
bznein 10592e1
Gofumpt
bznein 907de8e
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6384/ontimeo…
bznein 6787c74
Update modules/apps/transfer/keeper/relay_forwarding_test.go
bznein 37375ba
Update modules/apps/transfer/keeper/relay_forwarding_test.go
bznein 65a0d0a
Update modules/apps/transfer/keeper/relay_forwarding_test.go
bznein ca59adf
Update modules/apps/transfer/keeper/relay_forwarding_test.go
bznein 1492378
Add godoc to test.
bznein 288f5f6
Changed trace construction
bznein d4e9b59
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6384/ontimeo…
bznein a70e56d
Update modules/apps/transfer/keeper/relay_forwarding_test.go
bznein 6a33a57
remove error msg parameter from helper function
bznein 7fb5569
Add test for forwarded packet
bznein 774d971
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6384/ontimeo…
bznein d1736dc
Delete packet when not needed anymore.
bznein 8c8feeb
Move deletion of packet in a single place.
bznein 24f82d6
Reintroduce newline
bznein 6528515
Do not ignore error.
bznein caa3902
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6546/deletep…
bznein bec616f
PR feedback.
bznein ad4e6f6
Construct packet for B ack check.
bznein 3acd732
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6384/ontimeo…
bznein 61884f0
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6546/deletep…
bznein 139facf
PR feedback
bznein f9c1e70
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6546/deletep…
gjermundgaraba fdd769f
Pass packet to acknowledgeforwardedpacket
bznein d532007
revert unwanted change
bznein db52296
Another unwanted change
bznein 8d06bc3
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6546/deletep…
bznein b6684da
Better signature and fix source/dest
bznein a5c8729
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6546/deletep…
crodriguezvega 432fd1f
Added one more test.
bznein 265de48
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6546/deletep…
bznein fc5410e
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6546/deletep…
bznein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add checks in our testing for deletion of the right packet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for the
OnAcknowledgment
, for the timeout case I have #6596 in review and I'll ad it to that test once we merge this.