Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: modify ica controller NewIBCMiddleware to default to nil auth module #6749

Merged
merged 8 commits into from
Jul 3, 2024
Merged

imp: modify ica controller NewIBCMiddleware to default to nil auth module #6749

merged 8 commits into from
Jul 3, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #3020

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Jul 3, 2024
@crodriguezvega crodriguezvega linked an issue Jul 3, 2024 that may be closed by this pull request
modify ICA controller NewIBCMiddleware to default to nil auth module #3020
Closed
3 tasks
colin-axner
colin-axner approved these changes Jul 3, 2024
View reviewed changes
docs/docs/05-migrations/13-v8-to-v9.md Outdated Show resolved Hide resolved
DimitrisJim
DimitrisJim approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

damiannolan
damiannolan approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-axner colin-axner enabled auto-merge July 3, 2024 15:05
@crodriguezvega crodriguezvega disabled auto-merge July 3, 2024 19:38
@crodriguezvega crodriguezvega enabled auto-merge July 3, 2024 19:38
@crodriguezvega crodriguezvega added this pull request to the merge queue Jul 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Merged via the queue into main with commit 356e433 Jul 3, 2024
28 checks passed
@crodriguezvega crodriguezvega deleted the carlos/3020-modify-ica-controller-newibcmiddleware-to-default-to-nil-auth-module branch July 3, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@bznein bznein Awaiting requested review from bznein

Assignees
No one assigned
Labels
priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modify ICA controller NewIBCMiddleware to default to nil auth module
4 participants
@crodriguezvega @damiannolan @DimitrisJim @colin-axner