-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(state!): check upgrade compatibility in channel upgrade confirm #6935
Merged
crodriguezvega
merged 1 commit into
main
from
carlos/check-upgrade-compatibility-confirm
Jul 25, 2024
Merged
fix(state!): check upgrade compatibility in channel upgrade confirm #6935
crodriguezvega
merged 1 commit into
main
from
carlos/check-upgrade-compatibility-confirm
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
July 24, 2024 09:57
crodriguezvega
added
backport-to-v9.0.x
backport-to-v8.4.x
priority
PRs that need prompt reviews
labels
Jul 24, 2024
Quality Gate passed for 'ibc-go'Issues Measures |
AdityaSripal
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crodriguezvega !!
sangier
approved these changes
Jul 24, 2024
damiannolan
approved these changes
Jul 24, 2024
gjermundgaraba
approved these changes
Jul 24, 2024
This was referenced Jul 25, 2024
10 tasks
crodriguezvega
added a commit
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for cosmos/ibc#1127.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.