chore: use expected errors in ica host test. #7181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
crodriguezvega
approved these changes
Aug 16, 2024
| @@ -171,7 +171,7 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenTry() { | |||
| ) (string, error) { | |||
| return "", fmt.Errorf("mock ica auth fails") | |||
| } | |||
| }, true, | |||
| }, nil, | |||
There was a problem hiding this comment.
We could move this test up together the success ones.
| @@ -291,7 +291,7 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenConfirm() { | |||
| ) error { | |||
| return fmt.Errorf("mock ica auth fails") | |||
| } | |||
| }, true, | |||
| }, nil, | |||
| }, | ||
| { | ||
| "invalid metadata bytestring", | ||
| func() { | ||
| // the try step will propose a new valid version | ||
| path.EndpointA.ChannelConfig.Version = "invalid-metadata-bytestring" | ||
| }, | ||
| true, | ||
| nil, |
There was a problem hiding this comment.
We could also relocate this one up.
| @@ -136,7 +136,7 @@ func (suite *KeeperTestSuite) TestNewKeeper() { | |||
| testCases := []struct { | |||
| name string | |||
| instantiateFn func() | |||
| expPass bool | |||
| exxPanicMsg string | |||
There was a problem hiding this comment.
Suggested change
| exxPanicMsg string | |
| expPanicMsg string |
There was a problem hiding this comment.
We could also just use panicMsg, since you use errMsg in other tests, but it's just a nit :)
chatton
approved these changes
Aug 19, 2024
|
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7180
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.