docs: update roadmap #7197
Draft
docs: update roadmap #7197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
crodriguezvega
commented
Aug 21, 2024
Comment on lines
+83
to
+88
| message PacketData { | ||
| string port_id = 1; // or app_name | ||
| string type = 2; // or version | ||
| string encoding = 3; | ||
| bytes value = 4; // the serialized bytes of the application's packet data | ||
| } |
There was a problem hiding this comment.
I took the liberty to put all this together in the same message (I know in the issue it's separate in two different structures, but thought that for clarity it would be possible to put it all together).
Comment on lines
+137
to
+138
| + string destination_port = 3; | ||
| + string destination_channel = 4; |
There was a problem hiding this comment.
Not sure if we will need this, but added it for now (if we use channel aliasing, we should be able to find the counterparty channel ID; and if we use a client ID, we should be able also to get the counterparty client ID that was stored with MsgProvideCounterparty).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to write some kind of cohesive narrative around the changes for port router and eureka, since there are some touch points between them, and even though there is a lot of good information in the issues, I thought it would be nice to glue all this together in a document.
This is not meant to be exhaustive, but more illustrative instead, so that someone can in a 5-minute read understand the overall picture. I can add more detail if there are things that people think should be added.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.