Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove capabilities methods from testing #7269

Merged
merged 1 commit into from
Sep 9, 2024
Merged

chore: remove capabilities methods from testing #7269

merged 1 commit into from
Sep 9, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Sep 9, 2024

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@bznein bznein changed the title chore: remove capabilities method from testing chore: remove capabilities methods from testing Sep 9, 2024
@bznein bznein marked this pull request as ready for review September 9, 2024 13:41
DimitrisJim
DimitrisJim approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More awesome diffs! 😎 Thanks for cleanup!

@bznein bznein added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 2ddd5cf Sep 9, 2024
70 checks passed
@bznein bznein deleted the bznein/removecaps/test branch September 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega crodriguezvega is a code owner

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bznein @damiannolan @DimitrisJim