Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attempt to fix panics for unresolvable imports by using GogoResolver #7277

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: attempt to fix panics for unresolvable imports by using GogoResolver #7277

merged 3 commits into from
Sep 10, 2024

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Sep 10, 2024 •
edited
Loading

Description

Uses the cosmos/gogoproto registry as opposed to including the entire merged global files registry.

closes: #7259

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@damiannolan
Copy link
Member Author

Publishing PR to run e2e test

@damiannolan damiannolan marked this pull request as ready for review September 10, 2024 15:22
@DimitrisJim
Copy link
Contributor

Publishing PR to run e2e test

I think this is only unit tested atm? Either way, would be great to see if this addresses things. I definitely think its good to limit what files we go through as much as possible.

DimitrisJim
DimitrisJim approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! See Julien left a comment in other PR that this addresses the issue. I guess this is the UX friendlier approach but we might want to think about switching to people specifying the allow list if this pops up again.

damiannolan
damiannolan commented Sep 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@damiannolan damiannolan added this pull request to the merge queue Sep 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
149 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Merged via the queue into main with commit 79ddda5 Sep 10, 2024
72 checks passed
@damiannolan damiannolan deleted the damian/fix-proto-range-files-resolver branch September 10, 2024 19:41
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@damiannolan @mergify
fix: attempt to fix panics for unresolvable imports by using GogoReso…
8214ae3 
…lver (#7277)

* fix: attempt to fix panics for unresolvable imports by using GogoResolver

* chore: add changelog

* chore: amend changelog

(cherry picked from commit 79ddda5)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
10 tasks
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@damiannolan @mergify
fix: attempt to fix panics for unresolvable imports by using GogoReso…
d1c056e 
…lver (#7277)

* fix: attempt to fix panics for unresolvable imports by using GogoResolver

* chore: add changelog

* chore: amend changelog

(cherry picked from commit 79ddda5)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Sep 10, 2024
Closed
10 tasks
DimitrisJim pushed a commit that referenced this pull request Sep 11, 2024
@mergify @damiannolan
fix: attempt to fix panics for unresolvable imports by using GogoReso…
34a0d01 
…lver (backport #7277) (#7281)

* fix: attempt to fix panics for unresolvable imports by using GogoResolver (#7277)

* fix: attempt to fix panics for unresolvable imports by using GogoResolver

* chore: add changelog

* chore: amend changelog

(cherry picked from commit 79ddda5)

# Conflicts:
#	CHANGELOG.md

* chore: address merge conflicts in changelog

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@bznein bznein Awaiting requested review from bznein

Assignees
No one assigned
Labels
backport-to-v7.8.x backport-to-v8.5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: newModuleQuerySafeAllowList panics
3 participants
@damiannolan @DimitrisJim @colin-axner