chore(packet-server): add queryServer to packet-server #7283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
force-pushed
the
jim/packet-server-query-server
branch
from
c8a6600
to
75f7379
Compare
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
chatton
approved these changes
Sep 11, 2024
Comment on lines
42
to
46
| creator, _ := q.ClientKeeper.GetCreator(sdkCtx, req.ClientId) | ||
| res.Creator = creator | ||
|
|
||
| counterparty, _ := q.GetCounterparty(sdkCtx, req.ClientId) | ||
| res.Counterparty = counterparty |
There was a problem hiding this comment.
is it safe to discard these found vars? Should we error out in this case instead of returning an empty response?
There was a problem hiding this comment.
oh, update, I remembered these can exist independetly until provide counterparty is called. I.e only creator and then only counterparty. I guess if both are not found I can error.
bznein
approved these changes
Sep 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds a query server to the packe server to bring in the removed query after the reshuffling of protos.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.