chore: add conversion function from PacketV1 to PacketV2 #7292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
changed the title
chatton
reviewed
Sep 12, 2024
| } | ||
|
|
||
| encoding := packet.Encoding | ||
| if encoding == "" { |
There was a problem hiding this comment.
maybe a strings.TrimSpace here too
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan,
srdtrk,
DimitrisJim,
crodriguezvega and
gjermundgaraba
as code owners
crodriguezvega
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Nice one, @bznein! Looks like there are some dependency bumps as well in the PR, maybe the base branch needs to resynced...
Base automatically changed from
cian/add-packet-v2-protos
to
feat/ibc-eureka
September 16, 2024 07:43
chatton
approved these changes
Sep 16, 2024
|
chatton
reviewed
Sep 16, 2024
| @@ -107,6 +107,8 @@ func (k Keeper) RecvPacket( | |||
| return "", channeltypes.ErrInvalidPacket | |||
| } | |||
|
|
|||
| // packetv2 := convert(packet) | |||
There was a problem hiding this comment.
whoops, this doesn't need to be here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.