Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all tags can be checked out with ibc-proto-compiler clone-sdk #16

Closed
5 tasks done
romac opened this issue Nov 10, 2020 · 1 comment
Closed
5 tasks done

Not all tags can be checked out with ibc-proto-compiler clone-sdk #16

romac opened this issue Nov 10, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@romac
Copy link
Member

romac commented Nov 10, 2020

Crate

ibc-proto-compiler

Summary of Bug

The --tag option introduced in informalsystems/hermes#369 allows checking out a specific tag with the following invocation

$ ibc-proto-compiler clone-sdk --tag v0.39.1-rc3 --path /tmp/sdk

Unfortunately, this works fine for many tags (eg. v0.39.1-rc3) but not for some others (eg. v0.40.0-rc2).
The latter will fail with Could not find tag v0.40.0-rc2 as git2 does not list v0.40.0-rc2 as part of the tags present in the checked out repository.

It might be that such tags cannot be found because they lack a corresponding tag object, which is usually created by passing either of -a or -s to the git tag command.

Version

ab094281d5c23eed1087fe649091c4d9c38da825

Steps to Reproduce

$ cd proto-compiler
$ cargo run -- clone-sdk --tag v0.40.0-rc2 --path /tmp/sdk
[info ] Found Cosmos SDK source at '/tmp/sdk'
[error] Could not find tag v0.40.0-rc2

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the bug Something isn't working label Nov 10, 2020
@romac romac self-assigned this Nov 10, 2020
@romac romac removed their assignment Dec 1, 2021
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
@romac
Copy link
Member Author

romac commented Sep 27, 2023

We do not use this command anymore, and instead are checking the repositories directly via git in the scripts/sync-protobuf.sh script.

@romac romac closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant