Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --tag option to the clone-sdk command #369

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Add a --tag option to the clone-sdk command #369

merged 3 commits into from
Nov 10, 2020

Conversation

romac
Copy link
Member

@romac romac commented Nov 5, 2020

Closes: #XXX

Description

Add a --tag option to the clone-sdk command to check out a tag instead of a commit.

Caveat

For some reason I have yet to figure out, not all tags can be checked out this way, eg. v0.40.0-rc2 fails whereas v0.39.1-rc3 works just fine. Will investigate further!


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac requested a review from ancazamfir November 5, 2020 20:13
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ancazamfir
Copy link
Collaborator

Ah, I noticed it doesn't work for v0.40.0-rc0...and then saw your comment :)

@romac romac marked this pull request as ready for review November 9, 2020 17:19
@romac romac merged commit ab09428 into master Nov 10, 2020
@romac romac deleted the romac/proto-tag branch November 10, 2020 09:40
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Add a --tag option to the clone-sdk command

* Update changelog

* Update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants