Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract mocks protos from the ibc-proto crate into the ibc crate #19

Open
4 tasks done
romac opened this issue Oct 19, 2020 · 0 comments
Open
4 tasks done

Extract mocks protos from the ibc-proto crate into the ibc crate #19

romac opened this issue Oct 19, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@romac
Copy link
Member

romac commented Oct 19, 2020

Summary

Extract mocks protos from the ibc-proto crate into the ibc crate.

Problem Definition

@ancazamfir pointed out to me today that the mock proto are kept in sync with our codebase while the rest of the proto definitions might evolve at a different pace. This causes a lot of pain when we want to update the mocks without doing a full release of the ibc-proto crate, or when we want to do an update and release of the ibc-proto crate independently from the rest of the ibc-rs project.

Proposal

Extract the mock protos from the ibc-proto crate into the ibc crate, and compile them to Rust automatically at build time with `build.rs.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac self-assigned this Oct 19, 2020
@romac romac removed their assignment Dec 1, 2021
@romac romac added the good first issue Good for newcomers label Mar 25, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
hu55a1n1 pushed a commit that referenced this issue Sep 29, 2022
* add codecov token

* fix tendermint dep

* add token to repo

* fix fmt

* Fix clippy warning

* Switch back CI to stable Rust

* Adapt rustfmt config for stable

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant