Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using serde for deserializing prost proto structs #22

Closed
greg-szabo opened this issue Jul 14, 2020 · 0 comments · Fixed by informalsystems/hermes#152
Closed

Using serde for deserializing prost proto structs #22

greg-szabo opened this issue Jul 14, 2020 · 0 comments · Fixed by informalsystems/hermes#152
Assignees
@greg-szabo

Comments

@greg-szabo
Copy link
Member

Is it possible to use serde's deserialization with prost's Proto* structs into our own structs? (The pattern that we tried with CommitSig in Tendermint-rs.) It would help with understanding the code and highlighting the right parts for the developer.

Also this would go away:
https://github.com/informalsystems/ibc-rs/blob/fa4cf48a9d3d2e675a94c2ee6dd5e2c9963676b1/modules/src/ics03_connection/query.rs#L115-L120
@greg-szabo greg-szabo changed the title Using serde for deserializaing with prost Using serde for deserializing with prost Jul 14, 2020
@greg-szabo greg-szabo changed the title Using serde for deserializing with prost Using serde for deserializing prost proto structs Jul 14, 2020
@greg-szabo greg-szabo assigned adizere and andynog and unassigned adizere and andynog Jul 14, 2020
@greg-szabo greg-szabo mentioned this issue Jul 16, 2020
Merged
6 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
hu55a1n1 pushed a commit that referenced this issue Sep 29, 2022
@romac
Run cargo-audit daily or when dependencies have changed (#22)
43236fa 
* Run cargo-audit daily and when dependencies have changed

See informalsystems/tendermint-rs#144 (comment)

* Change actions/checkout back to v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg-szabo greg-szabo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generic query, channel query and reduce code informalsystems/hermes
3 participants
@adizere @greg-szabo @andynog