Skip to content

Commit

Permalink
ADR 012: Handlers validation and execution separation (#153)
Browse files Browse the repository at this point in the history
* init adr 12

* Host based API

* Add appendices

* Add section on event logging

* Add .changelog entry

* Fix TypedStore associated type (syntax only)

* Update docs/architecture/adr-012-handlers-redesign.md

Co-authored-by: Philippe Laferrière <plafer@protonmail.com>

* validation vs execution clarifications

* Move ValidationContext and ExecutionContext methods to appendix

* Context clarification

* Rework Host-based API section

* ValidationContext and ExecutionContext clarification

* Move Event logging section + misc

* typo

* Remove statement. Was mentioned earlier already.

* IbcStore blanket implementation

* IbcValueForPath rework

* Remove IbcSerde from main ADR

* TypedStore -> SubStore

* diagram

* Update docs/architecture/adr-012-handlers-redesign.md

Co-authored-by: Sean Chen <seanchen11235@gmail.com>

* Update docs/architecture/adr-012-handlers-redesign.md

Co-authored-by: Sean Chen <seanchen11235@gmail.com>

* Update docs/architecture/adr-012-handlers-redesign.md

Co-authored-by: Sean Chen <seanchen11235@gmail.com>

* add context for why the validation/execution split is necessary

* add trait bounds

* Rename ADR012 -> ADR005

* Apply suggestions from code review

Change ADR status from Proposed to Accepted

Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Philippe Laferriere <plafer@protonmail.com>
Co-authored-by: Sean Chen <seanchen11235@gmail.com>
  • Loading branch information
3 people authored Oct 6, 2022
1 parent c2be8e5 commit 086e705
Show file tree
Hide file tree
Showing 4 changed files with 643 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Propose ADR05 for handlers validation and execution separation.
([#2582](https://github.com/informalsystems/ibc-rs/pull/2582)).
13 changes: 7 additions & 6 deletions docs/architecture/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ To suggest an ADR, please make use of the [ADR template](./adr-template.md) prov

## Table of Contents

| ADR \# | Description | Status |
|-----------------------------------------------------------|-------------------------------------------------------|----------|
| [001](./adr-001-handler-implementation.md) | IBC handlers implementation | Accepted |
| [002](./adr-002-error.md) | Error Management | Accepted |
| [003](./adr-003-ics20-implementation.md) | ICS20 implementation | Accepted |
| [004](./adr-004-light-client-crates-extraction.md) | Light client crates extraction | Accepted |
| ADR \# | Description | Status |
|----------------------------------------------------|-------------------------------------------------------|----------|
| [001](./adr-001-handler-implementation.md) | IBC handlers implementation | Accepted |
| [002](./adr-002-error.md) | Error Management | Accepted |
| [003](./adr-003-ics20-implementation.md) | ICS20 implementation | Accepted |
| [004](./adr-004-light-client-crates-extraction.md) | Light client crates extraction | Accepted |
| [005](./adr-005-handlers-redesign.md) | Handlers validation and execution separation | Accepted |
Loading

0 comments on commit 086e705

Please sign in to comment.