fix(ibc-app-nft-transfer): compile without default features (#1195)

* enable cargo feature check * fix no default compile * nit
cosmos · Apr 24, 2024 · 7e50323 · 7e50323
1 parent d03594c
commit 7e50323
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/rust.yaml b/.github/workflows/rust.yaml
@@ -35,7 +35,6 @@ env:
 
 jobs:
   check-features:
-    if: ${{ github.event_name != 'pull_request' }}
     name: Check features
     runs-on: ubuntu-latest
     timeout-minutes: 60

diff --git a/ibc-apps/ics721-nft-transfer/types/Cargo.toml b/ibc-apps/ics721-nft-transfer/types/Cargo.toml
@@ -20,11 +20,11 @@ all-features = true
 [dependencies]
 # external dependencies
 borsh           = { workspace = true, optional = true }
-base64          = { workspace = true }
+base64          = { workspace = true, features = ["alloc"] }
 derive_more     = { workspace = true }
 displaydoc      = { workspace = true }
-http            = "1.0.0"
-mime            = "0.3.17"
+http            = { version = "1.0.0" }
+mime            = { version = "0.3.17" }
 schemars        = { workspace = true, optional = true }
 serde           = { workspace = true, optional = true }
 serde_json      = { workspace = true }