Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChanOpenConfirm handler set the expected counterparty channel id incorrectly to None #396

Closed
Farhad-Shabani opened this issue Feb 5, 2023 · 0 comments · Fixed by #397
Closed

ChanOpenConfirm handler set the expected counterparty channel id incorrectly to None #396

Farhad-Shabani opened this issue Feb 5, 2023 · 0 comments · Fixed by #397
Assignees
@Farhad-Shabani
Labels
A: bug Admin: something isn't working A: urgent Admin: high priority issue
Milestone
v0.28.0

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Feb 5, 2023 •
edited
Loading

Bug Summary

Related to #354
Opening a channel fails inside ChanOpenConfirm handler when it is instantiated from an ibc-rs implemented chain

Details

Version

v0.27.0
@Farhad-Shabani Farhad-Shabani added A: bug Admin: something isn't working A: urgent Admin: high priority issue labels Feb 5, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 5, 2023
@Farhad-Shabani Farhad-Shabani changed the title ChanOpenConfirm handler set the counterparty channel id incorrectly to None ChanOpenConfirm handler set the expected counterparty channel id incorrectly to None Feb 5, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 5, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🔖 Needs Review in ibc-rs Feb 6, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Feb 6, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 6, 2023
Closed
@github-project-automation github-project-automation bot moved this from 🔖 Needs Review to ✅ Done in ibc-rs Feb 6, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: Fix known bugs and issues, v0.28.0 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: bug Admin: something isn't working A: urgent Admin: high priority issue
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.28.0
Development

Successfully merging a pull request may close this issue.

Mend the counterparty state check of ChanOpenConfirm handler cosmos/ibc-rs
1 participant
@Farhad-Shabani