Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChanOpenConfirm fix #354

Merged
merged 3 commits into from
Jan 13, 2023
Merged

ChanOpenConfirm fix #354

merged 3 commits into from
Jan 13, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jan 13, 2023

Closes: #353

Note that #352 also fixes this already in the new validate().


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@plafer plafer requested a review from Farhad-Shabani January 13, 2023 21:34
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 61.01% // Head: 61.01% // No change to project coverage 👍

Coverage data is based on head (8fc9b22) compared to base (3ed2246).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files         124      124           
  Lines       14498    14498           
=======================================
  Hits         8846     8846           
  Misses       5652     5652           
Impacted Files Coverage Δ
...rc/core/ics04_channel/handler/chan_open_confirm.rs 83.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏
Should we patch this for our recent release? v0.26.1?

@Farhad-Shabani Farhad-Shabani merged commit a2a52b7 into main Jan 13, 2023
@Farhad-Shabani Farhad-Shabani deleted the plafer/353-open-confirm-fix branch January 13, 2023 22:08
@plafer
Copy link
Contributor Author

plafer commented Jan 13, 2023

Yes I'll do one on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChanOpenConfirm handler checks for the wrong counterparty state
2 participants