Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgConnectionOpenInit version field is ignored in handler #51

Closed
5 tasks
plafer opened this issue Apr 4, 2022 · 0 comments
Closed
5 tasks

MsgConnectionOpenInit version field is ignored in handler #51

plafer opened this issue Apr 4, 2022 · 0 comments
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Apr 4, 2022

Summary of Bug

In conn_open_init handler, the version field in the msg passed in argument is ignored.

Version

v0.13.0

Acceptance Criteria

The msg.version field is checked to be in the list of supported versions (as dictated by ConnectionReader::get_compatible_version()), and if so, is set as the only version in the ConnectionEnd. If the check fails, the handler fails.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer mentioned this issue Apr 4, 2022
Merged
6 tasks
@adizere adizere added the A: bug Admin: something isn't working label Apr 5, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adizere @plafer