Check version field of message in ConnOpenInit handler
#2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
changed the title
version field of message in ConnOpenInit handler
romac
reviewed
Apr 5, 2022
| want_pass: false, | ||
| }, | ||
| Test { | ||
| name: "No version in MsgConnectionOpenInit msg".to_string(), |
There was a problem hiding this comment.
Can we add a test for when there is a version mismatch?
romac
reviewed
Apr 5, 2022
romac
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-rs#51
Description
We previously ignored the version in the message when handling a
MsgConnOpenInit. This PR fixes this in a manner compliant with ICS 003.Relevant part of the spec is here (search for
A specific version can optionally be passed).PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.