Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up modules' errors #72

Closed
5 tasks
yito88 opened this issue Sep 8, 2021 · 0 comments
Closed
5 tasks

Clean up modules' errors #72

yito88 opened this issue Sep 8, 2021 · 0 comments

Comments

@yito88
Copy link
Contributor

yito88 commented Sep 8, 2021

Crate

IBC

Summary

We can clean up some modules' errors

Problem Definition

informalsystems/hermes#1283 (review)

there is an opportunity for more cleanup if we add an Ics03Connection variant to Ics04Error, because that will allow us to reuse errors from Ics03Error (and by extension Ics02Error using the Ics03Error::Ics02Client variant) and avoid redundant errors such as Ics04Error::ClientNotFound, MissingClientState, etc.

Proposal

Ics03Error can reuse Ics02Error, Ics04Error can recues Ics02Error and Ics03Error, and we remove redundant errors

Acceptance Criteria

Redundant errors are cleaned up


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
Fixes a collision between cosmos#72 and cosmos#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant