Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICS07] Add test to ensure PacketData keeps proper JSON encoding #763

Closed
Tracked by #807
Farhad-Shabani opened this issue Jul 14, 2023 · 0 comments · Fixed by #765
Closed
Tracked by #807

[ICS07] Add test to ensure PacketData keeps proper JSON encoding #763

Farhad-Shabani opened this issue Jul 14, 2023 · 0 comments · Fixed by #765
Assignees
@Farhad-Shabani
Labels
O: code-hygiene Objective: aims to improve code hygiene O: testing Objective: aims to improve testing coverage
Milestone
v0.43.1

Comments

@Farhad-Shabani
Copy link
Member

Background

When serializing PacketData to JSON, it should be converted to RawPacketData first. Encoding PacketData directly may not yield the same result. Nice to add a unit test for including the proper conversion. Additionally, trim places PacketData is used in our tests.

This originated from a discussion in #741 about whether can drop this serde attribute.
@Farhad-Shabani Farhad-Shabani added O: testing Objective: aims to improve testing coverage O: code-hygiene Objective: aims to improve code hygiene labels Jul 14, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Jul 14, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jul 14, 2023
This was referenced Jul 14, 2023
Merged
Closed
@Farhad-Shabani Farhad-Shabani added this to the v0.43.0 milestone Jul 17, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jul 18, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
O: code-hygiene Objective: aims to improve code hygiene O: testing Objective: aims to improve testing coverage
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.43.1
Development

Successfully merging a pull request may close this issue.

test: include PacketData serde test to keep proper JSON encoding cosmos/ibc-rs
1 participant
@Farhad-Shabani