test: include PacketData serde test to keep proper JSON encoding
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
==========================================
+ Coverage 71.13% 71.22% +0.08%
==========================================
Files 124 124
Lines 14779 14790 +11
==========================================
+ Hits 10513 10534 +21
+ Misses 4266 4256 -10
☔ View full report in Codecov by Sentry. |
rnbguy
requested changes
Jul 17, 2023
Co-authored-by: Rano | Ranadeep <ranadip.bswas@gmail.com> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com>
rnbguy
approved these changes
Jul 17, 2023
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
) * test: include PacketData test to keep proper JSON encoding * misc: add unclog * Update crates/ibc/src/applications/transfer/packet.rs Co-authored-by: Rano | Ranadeep <ranadip.bswas@gmail.com> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> * imp: add dummy_json_packet_data function --------- Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> Co-authored-by: Rano | Ranadeep <ranadip.bswas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #763
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.