-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: miscellaneous repository maintenance #1174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
=======================================
Coverage 64.33% 64.33%
=======================================
Files 229 229
Lines 22083 22083
=======================================
Hits 14208 14208
Misses 7875 7875 ☔ View full report in Codecov by Sentry. |
rnbguy
force-pushed
the
rano/chores
branch
5 times, most recently
from
April 24, 2024 11:26
eaf8a53
to
6bbb619
Compare
seanchen1991
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for making all these improvements! 🎉
actions-rust-lang/setup-rust-toolchain@v1 uses it already
7 tasks
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* use renamed branch * conventionalcommits-org is down * add missing changelog entry * rename to Makefile * use native concurrency option * upgrade substrate deps * remove redundant nix use * correct cw-check workflow file * use yml extension over yml * delete nix script * rm merge group trigger and always trigger on main * rm md link check from main * forbid concurrent runs for cw and no-std checks * nit * use actions-rust-lang/setup-rust-toolchain over actions-rs/toolchain * imp docker run * use cosmwasm/optimizer 0.15.1 * correct mount paths * validate checksum * .yaml over .yml https://yaml.org/faq.html * install cargo binary before wasm compile to avoid docker mount permission * fix permissions manually * conventionalcommits.org is up * update upload cw client action * correct download path * update cargo lockfiles * redundant Swatinem/rust-cache actions-rust-lang/setup-rust-toolchain@v1 uses it already * update release workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProofSpec
,LeafOp
,InnerSpec
#1160makefile
toMakefile
.cw-check
.rokroskar/workflow-run-cleanup-action
from Rust workflow over native concurrency support.Setupmerge_group
with correct workflow status checks.merge_group
trigger.main
.main
..yml
over.yaml
.yaml
over.yml
as workflow file extensions.actions-rust-lang/setup-rust-toolchain
.Setting up
merge_group
is a bit complicated. To auto-remove a PR frommerge_group
, we need to add them asstatus_check
for merges ontomain
. But if a job is not executed (because of filtering of paths or trigger events), it will never be added inmerge_group
- because we need all status checks to be passed before merge.The
merge_group
only works for a workflow something as following:So the workflow is marked as successfully executed on PR, albeit it didn't run any job. When, the PR is put in
merge_group
, it will actually runmy-job
.PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.